From: Artem Bityutskiy <dedekind1@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: adrian.hunter@intel.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled
Date: Fri, 19 Aug 2011 19:08:51 +0300 [thread overview]
Message-ID: <1313770135.6607.71.camel@sauron> (raw)
In-Reply-To: <1313769360.6607.70.camel@sauron>
On Fri, 2011-08-19 at 18:55 +0300, Artem Bityutskiy wrote:
> On Thu, 2011-08-11 at 12:29 +0200, Michal Marek wrote:
> > With
> > $ grep -e UBIFS_FS_DEBUG -e DYNAMIC_DEBUG .config
> > # CONFIG_UBIFS_FS_DEBUG is not set
> > CONFIG_DYNAMIC_DEBUG=y
> >
> > Debug messages are kept in the object files due to the
> > dynamic_pr_debug() macro, even if they are never going to be printed:
> > $ make fs/ubifs/super.o
> > $ strings fs/ubifs/super.o | grep 'compiled on'
> > compiled on: Aug 11 2011 at 12:21:38
> >
> > Use plain printk to fix this.
> >
> > Signed-off-by: Michal Marek <mmarek@suse.cz>
>
> Good catch, thanks! Pushed to ubifs-2.6.git, thanks!
There is a similar issue in UBI - just fixed it. I'll send this to Linus
soon, as this is a regression (blown-up binaries even though debugging
is disabled).
--
Best Regards,
Artem Bityutskiy
prev parent reply other threads:[~2011-08-19 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 10:29 [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled Michal Marek
2011-08-19 15:55 ` Artem Bityutskiy
2011-08-19 16:08 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313770135.6607.71.camel@sauron \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox