From: Vincent Palatin <vpalatin@chromium.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
Alan Stern <stern@rowland.harvard.edu>,
Linux PCI <linux-pci@vger.kernel.org>
Cc: Olof Johansson <olofj@chromium.org>,
Sameer Nanda <snanda@chromium.org>,
Ming Lei <tom.leiming@gmail.com>,
linux-kernel@vger.kernel.org,
Vincent Palatin <vpalatin@chromium.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: [RFC] PM / Runtime: decrease verbosity in kernel log
Date: Fri, 16 Sep 2011 15:15:53 -0700 [thread overview]
Message-ID: <1316211355-2888-1-git-send-email-vpalatin@chromium.org> (raw)
When activating the PCI runtime PM on a laptop, my kernel log is filled with
messages such as the following ones and can be hardly read to find interesting
information:
ehci_hcd 0000:00:1d.7: PME# disabled
ehci_hcd 0000:00:1d.7: PCI INT A -> GSI 16 (level, low) -> IRQ 16
ehci_hcd 0000:00:1d.7: setting latency timer to 64
ehci_hcd 0000:00:1d.7: PCI INT A disabled
ehci_hcd 0000:00:1d.7: PME# enabled
ehci_hcd 0000:00:1d.7: BAR 0: set to [mem 0x92205000-0x922053ff] (PCI address [0x92205000-0x922053ff])
ehci_hcd 0000:00:1d.7: restoring config space at offset 0xf (was 0x100, writing 0x10b)
ehci_hcd 0000:00:1d.7: restoring config space at offset 0x1 (was 0x2900000, writing 0x2900002)
ehci_hcd 0000:00:1d.7: PME# disabled
ehci_hcd 0000:00:1d.7: PCI INT A -> GSI 16 (level, low) -> IRQ 16
ehci_hcd 0000:00:1d.7: setting latency timer to 64
ehci_hcd 0000:00:1d.7: PCI INT A disabled
ehci_hcd 0000:00:1d.7: PME# enabled
ehci_hcd 0000:00:1d.7: BAR 0: set to [mem 0x92205000-0x922053ff]
All those messages are triggered by the following cause, the laptop has a USB
3G modem with USB autosuspend activated. The USB device will wake up about
every 30s to do some network related activities. Every time, the modem wakes
up this triggers the wake up of the attached EHCI/PCI USB host controller
which reconfigures its PCI interface, then everything go back to a suspended mode.
Having the same 10 lines of log repeated is not really useful, but I probably
cannot totally remove them since there are somewhat useful for PCI hotplug
users and other PCI debugging.
So, my proposal is to create a new dev_printk macro : "dev_printk_norpm" which
outputs traces only when the device has not the runtime PM activated,
and guard those traces with it.
(cf the 2 patches in this thread as a PoC)
--
Vincent
next reply other threads:[~2011-09-16 22:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 22:15 Vincent Palatin [this message]
2011-09-16 22:15 ` [PATCH 1/2] PM / Runtime: add conditional trace macro Vincent Palatin
2011-09-16 22:15 ` [PATCH 2/2] PM / Runtime: make PCI traces quieter Vincent Palatin
2011-09-17 13:23 ` [RFC] PM / Runtime: decrease verbosity in kernel log Alan Stern
2011-09-19 16:20 ` Vincent Palatin
2011-09-19 21:08 ` Rafael J. Wysocki
2011-09-21 17:24 ` Vincent Palatin
2011-09-21 18:05 ` [PATCH] PM / Runtime: make PCI traces quieter Vincent Palatin
2011-09-21 18:29 ` Rafael J. Wysocki
2011-11-28 19:15 ` Vincent Palatin
2011-12-05 19:19 ` Jesse Barnes
2011-12-05 19:51 ` Vincent Palatin
2011-12-05 19:59 ` Jesse Barnes
2011-09-21 18:22 ` [RFC] PM / Runtime: decrease verbosity in kernel log Yinghai Lu
2011-09-21 18:28 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316211355-2888-1-git-send-email-vpalatin@chromium.org \
--to=vpalatin@chromium.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=rjw@sisk.pl \
--cc=snanda@chromium.org \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox