From: Vincent Palatin <vpalatin@chromium.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
Alan Stern <stern@rowland.harvard.edu>,
Linux PCI <linux-pci@vger.kernel.org>
Cc: Olof Johansson <olofj@chromium.org>,
Sameer Nanda <snanda@chromium.org>,
Ming Lei <tom.leiming@gmail.com>,
linux-kernel@vger.kernel.org,
Vincent Palatin <vpalatin@chromium.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: [PATCH] PM / Runtime: make PCI traces quieter
Date: Wed, 21 Sep 2011 11:05:08 -0700 [thread overview]
Message-ID: <1316628308-32580-1-git-send-email-vpalatin@chromium.org> (raw)
In-Reply-To: <CAP_ceTyXLO=mv1Ott=g3mG0y+Q+VUM3N8CA-Fqa-_=uj7LTbmw@mail.gmail.com>
When the runtime PM is activated on PCI, if a device switches state frequently
(e.g. an EHCI controller with autosuspending USB devices connected)
the PCI configuration traces might be very verbose in the kernel log.
Let's guard those traces with DEBUG condition.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
---
arch/x86/pci/i386.c | 2 +-
drivers/acpi/pci_irq.c | 10 +++++-----
drivers/pci/pci.c | 5 ++---
drivers/pci/setup-res.c | 6 +++---
4 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
index 494f2e7..eb5d20b 100644
--- a/arch/x86/pci/i386.c
+++ b/arch/x86/pci/i386.c
@@ -269,7 +269,7 @@ void pcibios_set_master(struct pci_dev *dev)
lat = pcibios_max_latency;
else
return;
- dev_printk(KERN_DEBUG, &dev->dev, "setting latency timer to %d\n", lat);
+ dev_dbg(&dev->dev, "setting latency timer to %d\n", lat);
pci_write_config_byte(dev, PCI_LATENCY_TIMER, lat);
}
diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
index 7f9eba9..0eefa12 100644
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -487,10 +487,10 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
else
link_desc[0] = '\0';
- dev_info(&dev->dev, "PCI INT %c%s -> GSI %u (%s, %s) -> IRQ %d\n",
- pin_name(pin), link_desc, gsi,
- (triggering == ACPI_LEVEL_SENSITIVE) ? "level" : "edge",
- (polarity == ACPI_ACTIVE_LOW) ? "low" : "high", dev->irq);
+ dev_dbg(&dev->dev, "PCI INT %c%s -> GSI %u (%s, %s) -> IRQ %d\n",
+ pin_name(pin), link_desc, gsi,
+ (triggering == ACPI_LEVEL_SENSITIVE) ? "level" : "edge",
+ (polarity == ACPI_ACTIVE_LOW) ? "low" : "high", dev->irq);
return 0;
}
@@ -524,6 +524,6 @@ void acpi_pci_irq_disable(struct pci_dev *dev)
* (e.g. PCI_UNDEFINED_IRQ).
*/
- dev_info(&dev->dev, "PCI INT %c disabled\n", pin_name(pin));
+ dev_dbg(&dev->dev, "PCI INT %c disabled\n", pin_name(pin));
acpi_unregister_gsi(gsi);
}
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 0ce6742..d339c30 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -964,7 +964,7 @@ void pci_restore_state(struct pci_dev *dev)
for (i = 15; i >= 0; i--) {
pci_read_config_dword(dev, i * 4, &val);
if (val != dev->saved_config_space[i]) {
- dev_printk(KERN_DEBUG, &dev->dev, "restoring config "
+ dev_dbg(&dev->dev, "restoring config "
"space at offset %#x (was %#x, writing %#x)\n",
i, val, (int)dev->saved_config_space[i]);
pci_write_config_dword(dev,i * 4,
@@ -1531,8 +1531,7 @@ void pci_pme_active(struct pci_dev *dev, bool enable)
}
out:
- dev_printk(KERN_DEBUG, &dev->dev, "PME# %s\n",
- enable ? "enabled" : "disabled");
+ dev_dbg(&dev->dev, "PME# %s\n", enable ? "enabled" : "disabled");
}
/**
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index 51a9095..3878fe9 100644
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -84,9 +84,9 @@ void pci_update_resource(struct pci_dev *dev, int resno)
}
}
res->flags &= ~IORESOURCE_UNSET;
- dev_info(&dev->dev, "BAR %d: set to %pR (PCI address [%#llx-%#llx])\n",
- resno, res, (unsigned long long)region.start,
- (unsigned long long)region.end);
+ dev_dbg(&dev->dev, "BAR %d: set to %pR (PCI address [%#llx-%#llx])\n",
+ resno, res, (unsigned long long)region.start,
+ (unsigned long long)region.end);
}
int pci_claim_resource(struct pci_dev *dev, int resource)
--
1.7.3.1
next prev parent reply other threads:[~2011-09-21 18:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 22:15 [RFC] PM / Runtime: decrease verbosity in kernel log Vincent Palatin
2011-09-16 22:15 ` [PATCH 1/2] PM / Runtime: add conditional trace macro Vincent Palatin
2011-09-16 22:15 ` [PATCH 2/2] PM / Runtime: make PCI traces quieter Vincent Palatin
2011-09-17 13:23 ` [RFC] PM / Runtime: decrease verbosity in kernel log Alan Stern
2011-09-19 16:20 ` Vincent Palatin
2011-09-19 21:08 ` Rafael J. Wysocki
2011-09-21 17:24 ` Vincent Palatin
2011-09-21 18:05 ` Vincent Palatin [this message]
2011-09-21 18:29 ` [PATCH] PM / Runtime: make PCI traces quieter Rafael J. Wysocki
2011-11-28 19:15 ` Vincent Palatin
2011-12-05 19:19 ` Jesse Barnes
2011-12-05 19:51 ` Vincent Palatin
2011-12-05 19:59 ` Jesse Barnes
2011-09-21 18:22 ` [RFC] PM / Runtime: decrease verbosity in kernel log Yinghai Lu
2011-09-21 18:28 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316628308-32580-1-git-send-email-vpalatin@chromium.org \
--to=vpalatin@chromium.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=rjw@sisk.pl \
--cc=snanda@chromium.org \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox