From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name
Date: Wed, 5 Oct 2011 07:03:56 +0100 [thread overview]
Message-ID: <1317794636.24742.3.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <1317657968.20367.35.camel@twins>
On Mon, 2011-10-03 at 17:06 +0100, Peter Zijlstra wrote:
> On Mon, 2011-10-03 at 13:01 +0100, Ian Campbell wrote:
> > Noticed this while poking around. Seems like the code was lifted a bit
> > more thoroughly from the migration thread mgmt code than the author of
> > the preceding comment intended...
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > --- a/kernel/stop_machine.c
> > +++ b/kernel/stop_machine.c
> > @@ -312,7 +312,7 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
> > p = kthread_create_on_node(cpu_stopper_thread,
> > stopper,
> > cpu_to_node(cpu),
> > - "migration/%d", cpu);
> > + "stopper/%d", cpu);
> > if (IS_ERR(p))
> > return notifier_from_errno(PTR_ERR(p));
> > get_task_struct(p);
> >
>
> IIRC it was because userspace already knew about the migration thread
> and we didn't want to confuse things further. But yeah, its not
> particularly important.
I'm not sure what knowledge userspace has of either kernel thread but
fair enough, patch withdrawn.
Ian.
prev parent reply other threads:[~2011-10-05 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 12:01 [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name Ian Campbell
2011-10-03 16:06 ` Peter Zijlstra
2011-10-05 6:03 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317794636.24742.3.camel@dagon.hellion.org.uk \
--to=ian.campbell@eu.citrix.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox