From: Peter Zijlstra <peterz@infradead.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name
Date: Mon, 03 Oct 2011 18:06:07 +0200 [thread overview]
Message-ID: <1317657968.20367.35.camel@twins> (raw)
In-Reply-To: <1317643317.21903.36.camel@zakaz.uk.xensource.com>
On Mon, 2011-10-03 at 13:01 +0100, Ian Campbell wrote:
> Noticed this while poking around. Seems like the code was lifted a bit
> more thoroughly from the migration thread mgmt code than the author of
> the preceding comment intended...
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> --- a/kernel/stop_machine.c
> +++ b/kernel/stop_machine.c
> @@ -312,7 +312,7 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
> p = kthread_create_on_node(cpu_stopper_thread,
> stopper,
> cpu_to_node(cpu),
> - "migration/%d", cpu);
> + "stopper/%d", cpu);
> if (IS_ERR(p))
> return notifier_from_errno(PTR_ERR(p));
> get_task_struct(p);
>
IIRC it was because userspace already knew about the migration thread
and we didn't want to confuse things further. But yeah, its not
particularly important.
next prev parent reply other threads:[~2011-10-03 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 12:01 [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name Ian Campbell
2011-10-03 16:06 ` Peter Zijlstra [this message]
2011-10-05 6:03 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317657968.20367.35.camel@twins \
--to=peterz@infradead.org \
--cc=Ian.Campbell@citrix.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox