* [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name
@ 2011-10-03 12:01 Ian Campbell
2011-10-03 16:06 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2011-10-03 12:01 UTC (permalink / raw)
To: Tejun Heo, Andrew Morton, H. Peter Anvin, Eric Dumazet; +Cc: linux-kernel
Noticed this while poking around. Seems like the code was lifted a bit
more thoroughly from the migration thread mgmt code than the author of
the preceding comment intended...
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
--- a/kernel/stop_machine.c
+++ b/kernel/stop_machine.c
@@ -312,7 +312,7 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
p = kthread_create_on_node(cpu_stopper_thread,
stopper,
cpu_to_node(cpu),
- "migration/%d", cpu);
+ "stopper/%d", cpu);
if (IS_ERR(p))
return notifier_from_errno(PTR_ERR(p));
get_task_struct(p);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name
2011-10-03 12:01 [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name Ian Campbell
@ 2011-10-03 16:06 ` Peter Zijlstra
2011-10-05 6:03 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2011-10-03 16:06 UTC (permalink / raw)
To: Ian Campbell
Cc: Tejun Heo, Andrew Morton, H. Peter Anvin, Eric Dumazet,
linux-kernel
On Mon, 2011-10-03 at 13:01 +0100, Ian Campbell wrote:
> Noticed this while poking around. Seems like the code was lifted a bit
> more thoroughly from the migration thread mgmt code than the author of
> the preceding comment intended...
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> --- a/kernel/stop_machine.c
> +++ b/kernel/stop_machine.c
> @@ -312,7 +312,7 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
> p = kthread_create_on_node(cpu_stopper_thread,
> stopper,
> cpu_to_node(cpu),
> - "migration/%d", cpu);
> + "stopper/%d", cpu);
> if (IS_ERR(p))
> return notifier_from_errno(PTR_ERR(p));
> get_task_struct(p);
>
IIRC it was because userspace already knew about the migration thread
and we didn't want to confuse things further. But yeah, its not
particularly important.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name
2011-10-03 16:06 ` Peter Zijlstra
@ 2011-10-05 6:03 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2011-10-05 6:03 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Tejun Heo, Andrew Morton, H. Peter Anvin, Eric Dumazet,
linux-kernel@vger.kernel.org
On Mon, 2011-10-03 at 17:06 +0100, Peter Zijlstra wrote:
> On Mon, 2011-10-03 at 13:01 +0100, Ian Campbell wrote:
> > Noticed this while poking around. Seems like the code was lifted a bit
> > more thoroughly from the migration thread mgmt code than the author of
> > the preceding comment intended...
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > --- a/kernel/stop_machine.c
> > +++ b/kernel/stop_machine.c
> > @@ -312,7 +312,7 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
> > p = kthread_create_on_node(cpu_stopper_thread,
> > stopper,
> > cpu_to_node(cpu),
> > - "migration/%d", cpu);
> > + "stopper/%d", cpu);
> > if (IS_ERR(p))
> > return notifier_from_errno(PTR_ERR(p));
> > get_task_struct(p);
> >
>
> IIRC it was because userspace already knew about the migration thread
> and we didn't want to confuse things further. But yeah, its not
> particularly important.
I'm not sure what knowledge userspace has of either kernel thread but
fair enough, patch withdrawn.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-05 6:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-03 12:01 [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name Ian Campbell
2011-10-03 16:06 ` Peter Zijlstra
2011-10-05 6:03 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox