From: Joe Perches <joe@perches.com>
To: Jake Burton <jake5991@live.com>
Cc: gregkh@suse.de, abbotti@mev.co.uk, fmhess@users.sourceforge.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: Subject: [PATCH]
Date: Sat, 08 Oct 2011 11:23:26 -0700 [thread overview]
Message-ID: <1318098206.1844.3.camel@Joe-Laptop> (raw)
In-Reply-To: <BLU0-SMTP400327EB20018169910A6BAA2FF0@phx.gbl>
On Sat, 2011-10-08 at 19:01 +0100, Jake Burton wrote:
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
[]
> @@ -279,7 +279,7 @@ static const int ni_irqpin[] =
>
> struct ni_private {
> struct pnp_dev *isapnp_dev;
> - NI_PRIVATE_COMMON};
> +NI_PRIVATE_COMMON};
Hard to believe this is better. Maybe:
struct ni_private {
struct pnp_dev *isapnp_dev;
NI_PRIVATE_COMMON
};
It'd be better to inline NI_PRIVATE_COMMON,
whatever that is. There are 3 uses of that
really ugly #define.
prev parent reply other threads:[~2011-10-08 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-08 18:01 Subject: [PATCH] Jake Burton
2011-10-08 18:23 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318098206.1844.3.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=jake5991@live.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox