Subject: [PATCH]

Subject: [PATCH]

[Jake Burton]

>From bdfe02a6701656b757f8c59a226c01a50609f9fb Mon Sep 17 00:00:00 2001
From: Jake <jake5991@live.com>
Date: Sat, 8 Oct 2011 18:38:40 +0100
Subject: [PATCH] Staging: comedi: fix brace coding style issue and whitespace issue in ni_atmio.c
 This is a patch to the ni_atmio.c file that fixes up a brace and whitespace warning found by the checkpatch.pl tool.
Signed-off-by: Jake Burton <jake5991@live.com>

---
 drivers/staging/comedi/drivers/ni_atmio.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
index 3330b3d..e6c6c72 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -268,8 +268,8 @@ static const struct ni_board_struct ni_boards[] = {
 	 }
 };
 
-static const int ni_irqpin[] =
-    { -1, -1, -1, 0, 1, 2, -1, 3, -1, -1, 4, 5, 6, -1, -1, 7 };
+static const int ni_irqpin[] = {
+	-1, -1, -1, 0, 1, 2, -1, 3, -1, -1, 4, 5, 6, -1, -1, 7 };
 
 #define interrupt_pin(a)	(ni_irqpin[(a)])
 
@@ -279,7 +279,7 @@ static const int ni_irqpin[] =
 
 struct ni_private {
 	struct pnp_dev *isapnp_dev;
- NI_PRIVATE_COMMON};
+NI_PRIVATE_COMMON};
 #define devpriv ((struct ni_private *)dev->private)
 
 /* How we access registers */
-- 
1.7.4.1

Re: Subject: [PATCH]

[Joe Perches]

On Sat, 2011-10-08 at 19:01 +0100, Jake Burton wrote:
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
[]
> @@ -279,7 +279,7 @@ static const int ni_irqpin[] =
>  
>  struct ni_private {
>  	struct pnp_dev *isapnp_dev;
> - NI_PRIVATE_COMMON};
> +NI_PRIVATE_COMMON};

Hard to believe this is better.  Maybe:

struct ni_private {
	struct pnp_dev *isapnp_dev;
	NI_PRIVATE_COMMON
};

It'd be better to inline NI_PRIVATE_COMMON,
whatever that is.  There are 3 uses of that
really ugly #define.