The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] x86: fix an erroneous debug message
@ 2011-11-16  2:23 Zhang Rui
  2011-11-16  7:04 ` Yinghai Lu
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang Rui @ 2011-11-16  2:23 UTC (permalink / raw)
  To: LKML; +Cc: Yinghai Lu, Thomas Renninger

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

Fix an erroneous debug message.
    
Signed-off-by: Zhang Rui <rui.zhang@intel.com>

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 3c31fa9..1a691f5 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3641,8 +3641,8 @@ int io_apic_set_pci_routing(struct device *dev, int irq,
 	int node;
 
 	if (!IO_APIC_IRQ(irq)) {
-		apic_printk(APIC_QUIET,KERN_ERR "IOAPIC[%d]: Invalid reference to IRQ 0\n",
-			    irq_attr->ioapic);
+		apic_printk(APIC_QUIET,KERN_ERR "IOAPIC[%d]: Invalid reference to IRQ %d\n",
+			    irq_attr->ioapic, irq);
 		return -EINVAL;
 	}
 


[-- Attachment #2: fix-1.patch --]
[-- Type: text/x-patch, Size: 761 bytes --]

commit 73291d135bbf4b627bbf0cd99587f0d3fbbc82f4
Author: Zhang Rui <rui.zhang@intel.com>
Date:   Wed Nov 16 10:12:56 2011 +0800

    Fix a buggy debug messagge.
    
    Signed-off-by: Zhang Rui <rui.zhang@intel.com>

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 3c31fa9..1a691f5 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3641,8 +3641,8 @@ int io_apic_set_pci_routing(struct device *dev, int irq,
 	int node;
 
 	if (!IO_APIC_IRQ(irq)) {
-		apic_printk(APIC_QUIET,KERN_ERR "IOAPIC[%d]: Invalid reference to IRQ 0\n",
-			    irq_attr->ioapic);
+		apic_printk(APIC_QUIET,KERN_ERR "IOAPIC[%d]: Invalid reference to IRQ %d\n",
+			    irq_attr->ioapic, irq);
 		return -EINVAL;
 	}
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86: fix an erroneous debug message
  2011-11-16  2:23 [PATCH] x86: fix an erroneous debug message Zhang Rui
@ 2011-11-16  7:04 ` Yinghai Lu
  0 siblings, 0 replies; 2+ messages in thread
From: Yinghai Lu @ 2011-11-16  7:04 UTC (permalink / raw)
  To: Zhang Rui; +Cc: LKML, Thomas Renninger

On Tue, Nov 15, 2011 at 6:23 PM, Zhang Rui <rui.zhang@intel.com> wrote:
> Fix an erroneous debug message.
>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
>
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 3c31fa9..1a691f5 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -3641,8 +3641,8 @@ int io_apic_set_pci_routing(struct device *dev, int irq,
>        int node;
>
>        if (!IO_APIC_IRQ(irq)) {
> -               apic_printk(APIC_QUIET,KERN_ERR "IOAPIC[%d]: Invalid reference to IRQ 0\n",
> -                           irq_attr->ioapic);
> +               apic_printk(APIC_QUIET,KERN_ERR "IOAPIC[%d]: Invalid reference to IRQ %d\n",
> +                           irq_attr->ioapic, irq);
>                return -EINVAL;
>        }


Acked-by: Yinghai Lu <yinghai@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-16  7:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16  2:23 [PATCH] x86: fix an erroneous debug message Zhang Rui
2011-11-16  7:04 ` Yinghai Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox