* [PATCH] rt2x00: Use kcalloc instead of kzalloc to allocate array
@ 2011-11-29 21:08 Thomas Meyer
2011-12-03 9:20 ` Gertjan van Wingerde
2011-12-03 11:46 ` Ivo Van Doorn
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Meyer @ 2011-11-29 21:08 UTC (permalink / raw)
To: IvDoorn, gwingerde, helmut.schaa, linville, linux-wireless, users,
netdev, linux-kernel
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c 2011-11-28 19:36:47.770108588 +0100
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c 2011-11-28 19:54:53.495525543 +0100
@@ -831,11 +831,11 @@ static int rt2x00lib_probe_hw_modes(stru
if (spec->supported_rates & SUPPORT_RATE_OFDM)
num_rates += 8;
- channels = kzalloc(sizeof(*channels) * spec->num_channels, GFP_KERNEL);
+ channels = kcalloc(spec->num_channels, sizeof(*channels), GFP_KERNEL);
if (!channels)
return -ENOMEM;
- rates = kzalloc(sizeof(*rates) * num_rates, GFP_KERNEL);
+ rates = kcalloc(num_rates, sizeof(*rates), GFP_KERNEL);
if (!rates)
goto exit_free_channels;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rt2x00: Use kcalloc instead of kzalloc to allocate array
2011-11-29 21:08 [PATCH] rt2x00: Use kcalloc instead of kzalloc to allocate array Thomas Meyer
@ 2011-12-03 9:20 ` Gertjan van Wingerde
2011-12-03 11:46 ` Ivo Van Doorn
1 sibling, 0 replies; 3+ messages in thread
From: Gertjan van Wingerde @ 2011-12-03 9:20 UTC (permalink / raw)
To: Thomas Meyer
Cc: IvDoorn@gmail.com, helmut.schaa@googlemail.com,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
users@rt2x00.serialmonkey.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
On 29 nov. 2011, at 22:08, Thomas Meyer <thomas@m3y3r.de> wrote:
> The advantage of kcalloc is, that will prevent integer overflows which could
> result from the multiplication of number of elements and size and it is also
> a bit nicer to read.
>
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
>
> diff -u -p a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c 2011-11-28 19:36:47.770108588 +0100
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c 2011-11-28 19:54:53.495525543 +0100
> @@ -831,11 +831,11 @@ static int rt2x00lib_probe_hw_modes(stru
> if (spec->supported_rates & SUPPORT_RATE_OFDM)
> num_rates += 8;
>
> - channels = kzalloc(sizeof(*channels) * spec->num_channels, GFP_KERNEL);
> + channels = kcalloc(spec->num_channels, sizeof(*channels), GFP_KERNEL);
> if (!channels)
> return -ENOMEM;
>
> - rates = kzalloc(sizeof(*rates) * num_rates, GFP_KERNEL);
> + rates = kcalloc(num_rates, sizeof(*rates), GFP_KERNEL);
> if (!rates)
> goto exit_free_channels;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rt2x00: Use kcalloc instead of kzalloc to allocate array
2011-11-29 21:08 [PATCH] rt2x00: Use kcalloc instead of kzalloc to allocate array Thomas Meyer
2011-12-03 9:20 ` Gertjan van Wingerde
@ 2011-12-03 11:46 ` Ivo Van Doorn
1 sibling, 0 replies; 3+ messages in thread
From: Ivo Van Doorn @ 2011-12-03 11:46 UTC (permalink / raw)
To: Thomas Meyer
Cc: gwingerde, helmut.schaa, linville, linux-wireless, users, netdev,
linux-kernel
On Tue, Nov 29, 2011 at 10:08 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> The advantage of kcalloc is, that will prevent integer overflows which could
> result from the multiplication of number of elements and size and it is also
> a bit nicer to read.
>
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
>
> diff -u -p a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c 2011-11-28 19:36:47.770108588 +0100
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c 2011-11-28 19:54:53.495525543 +0100
> @@ -831,11 +831,11 @@ static int rt2x00lib_probe_hw_modes(stru
> if (spec->supported_rates & SUPPORT_RATE_OFDM)
> num_rates += 8;
>
> - channels = kzalloc(sizeof(*channels) * spec->num_channels, GFP_KERNEL);
> + channels = kcalloc(spec->num_channels, sizeof(*channels), GFP_KERNEL);
> if (!channels)
> return -ENOMEM;
>
> - rates = kzalloc(sizeof(*rates) * num_rates, GFP_KERNEL);
> + rates = kcalloc(num_rates, sizeof(*rates), GFP_KERNEL);
> if (!rates)
> goto exit_free_channels;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-03 11:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-29 21:08 [PATCH] rt2x00: Use kcalloc instead of kzalloc to allocate array Thomas Meyer
2011-12-03 9:20 ` Gertjan van Wingerde
2011-12-03 11:46 ` Ivo Van Doorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox