* [PATCH] mfd: tps65912: Initialize irq platform data properly
@ 2012-02-19 7:50 Axel Lin
2012-02-19 8:05 ` Hillf Danton
2012-02-23 16:39 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-02-19 7:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Margarita Olaya Cabrera, Liam Girdwood, Samuel Ortiz
irq_base of the tps65912 irq platform data should be
initialized with the board provided irq_base data.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/tps65912-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c
index 5fec23a..74fd8cb 100644
--- a/drivers/mfd/tps65912-core.c
+++ b/drivers/mfd/tps65912-core.c
@@ -151,7 +151,7 @@ int tps65912_device_init(struct tps65912 *tps65912)
goto err;
init_data->irq = pmic_plat_data->irq;
- init_data->irq_base = pmic_plat_data->irq;
+ init_data->irq_base = pmic_plat_data->irq_base;
ret = tps65912_irq_init(tps65912, init_data->irq, init_data);
if (ret < 0)
goto err;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: tps65912: Initialize irq platform data properly
2012-02-19 7:50 [PATCH] mfd: tps65912: Initialize irq platform data properly Axel Lin
@ 2012-02-19 8:05 ` Hillf Danton
2012-02-23 16:39 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Hillf Danton @ 2012-02-19 8:05 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Margarita Olaya Cabrera, Liam Girdwood,
Samuel Ortiz
On Sun, Feb 19, 2012 at 3:50 PM, Axel Lin <axel.lin@gmail.com> wrote:
> irq_base of the tps65912 irq platform data should be
> initialized with the board provided irq_base data.
>
The description only tells what you did, but why?
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/tps65912-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c
> index 5fec23a..74fd8cb 100644
> --- a/drivers/mfd/tps65912-core.c
> +++ b/drivers/mfd/tps65912-core.c
> @@ -151,7 +151,7 @@ int tps65912_device_init(struct tps65912 *tps65912)
> goto err;
>
> init_data->irq = pmic_plat_data->irq;
> - init_data->irq_base = pmic_plat_data->irq;
> + init_data->irq_base = pmic_plat_data->irq_base;
> ret = tps65912_irq_init(tps65912, init_data->irq, init_data);
> if (ret < 0)
> goto err;
> --
> 1.7.5.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: tps65912: Initialize irq platform data properly
2012-02-19 7:50 [PATCH] mfd: tps65912: Initialize irq platform data properly Axel Lin
2012-02-19 8:05 ` Hillf Danton
@ 2012-02-23 16:39 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-02-23 16:39 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Margarita Olaya Cabrera, Liam Girdwood
Hi Axel,
On Sun, Feb 19, 2012 at 03:50:11PM +0800, Axel Lin wrote:
> irq_base of the tps65912 irq platform data should be
> initialized with the board provided irq_base data.
Thanks, patch applied to my for-next and for-linus branches.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-23 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-19 7:50 [PATCH] mfd: tps65912: Initialize irq platform data properly Axel Lin
2012-02-19 8:05 ` Hillf Danton
2012-02-23 16:39 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox