From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@frijolero.org>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
lf_driver_backport@lists.linux-foundation.org
Subject: Re: [PATCH 2/4] compat: backport work_busy()
Date: Tue, 20 Mar 2012 13:07:03 +0100 [thread overview]
Message-ID: <1332245223.3329.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1332214021-9716-3-git-send-email-mcgrof@frijolero.org> (sfid-20120320_042853_043155_41AC0608)
On Mon, 2012-03-19 at 20:26 -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@frijolero.org>
>
> Best we can do is just tell the users of we are WORK_BUSY_PENDING
> for older kernels. The ckmake log:
[...]
> + * Test whether @work is currently pending or running. There is no
> + * synchronization around this function and the test result is
> + * unreliable and only useful as advisory hints or for debugging.
> + * Especially for reentrant wqs, the pending state might hide the
> + * running state.
What's this needed for? It seems if it's used only for hints/debugging
we should not need the function, or possibly simply return some
pointless combination like -1?
johannes
next prev parent reply other threads:[~2012-03-20 12:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 3:26 [PATCH 0/4] compat: March 19 backport work Luis R. Rodriguez
2012-03-20 3:26 ` [PATCH 1/4] compat: backport system work queues system_wq and system_long_wq Luis R. Rodriguez
2012-03-20 3:26 ` [PATCH 2/4] compat: backport work_busy() Luis R. Rodriguez
2012-03-20 12:07 ` Johannes Berg [this message]
2012-03-20 13:50 ` Luis R. Rodriguez
2012-03-20 14:29 ` [Lf_driver_backport] " Anderson Lizardo
2012-03-20 14:30 ` Anderson Lizardo
2012-03-20 3:27 ` [PATCH 3/4] compat: fix load time issue with kfifo backport Luis R. Rodriguez
2012-03-20 3:27 ` [PATCH 4/4] compat: add some tracing backport work Luis R. Rodriguez
2012-03-20 12:11 ` Johannes Berg
2012-03-20 12:16 ` Johannes Berg
2012-03-20 13:53 ` Luis R. Rodriguez
2012-03-22 4:29 ` Luis R. Rodriguez
2012-03-26 8:49 ` Johannes Berg
2012-03-26 12:58 ` Luis R. Rodriguez
2012-03-28 10:00 ` Luis R. Rodriguez
2012-04-05 12:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332245223.3329.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=lf_driver_backport@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@frijolero.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox