From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>
Cc: "Luis R. Rodriguez" <mcgrof@frijolero.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
lf_driver_backport@lists.linux-foundation.org
Subject: Re: [PATCH 4/4] compat: add some tracing backport work
Date: Thu, 05 Apr 2012 14:33:04 +0200 [thread overview]
Message-ID: <1333629184.3494.12.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120328100027.GA4420@bombadil.infradead.org> (sfid-20120328_120100_045553_52796B2A)
On Wed, 2012-03-28 at 06:00 -0400, Luis R. Rodriguez wrote:
> I've managed to backport tracing it seems, even when CONFIG_TRACEPOINTS
> is enabled.
Nope, you've managed to completely kill tracing.
> +#undef __DECLARE_TRACE
> +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, data_args) \
> + static inline void trace_##name(proto) \
> + { } \
> + static inline void trace_##name##_rcuidle(proto) \
> + { } \
> + static inline int \
> + register_trace_##name(void (*probe)(proto)) \
> + { \
> + return -ENOSYS; \
> + } \
> + static inline void \
> + unregister_trace_##name(void (*probe)(proto)) \
> + { \
> + return -ENOSYS; \
> + } \
> + static inline void check_trace_callback_type_##name(void (*cb)(data_proto)) \
> + { \
> + }
All of this simply completely kills tracing. Worse, the tracepoints get
registered, but their trace_##name functions do nothing, so you can
think that they're there, but they never record data ...
The old way was much better. Can we just let 2.6.24 and the other
ancients die in peace?
johannes
prev parent reply other threads:[~2012-04-05 12:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 3:26 [PATCH 0/4] compat: March 19 backport work Luis R. Rodriguez
2012-03-20 3:26 ` [PATCH 1/4] compat: backport system work queues system_wq and system_long_wq Luis R. Rodriguez
2012-03-20 3:26 ` [PATCH 2/4] compat: backport work_busy() Luis R. Rodriguez
2012-03-20 12:07 ` Johannes Berg
2012-03-20 13:50 ` Luis R. Rodriguez
2012-03-20 14:29 ` [Lf_driver_backport] " Anderson Lizardo
2012-03-20 14:30 ` Anderson Lizardo
2012-03-20 3:27 ` [PATCH 3/4] compat: fix load time issue with kfifo backport Luis R. Rodriguez
2012-03-20 3:27 ` [PATCH 4/4] compat: add some tracing backport work Luis R. Rodriguez
2012-03-20 12:11 ` Johannes Berg
2012-03-20 12:16 ` Johannes Berg
2012-03-20 13:53 ` Luis R. Rodriguez
2012-03-22 4:29 ` Luis R. Rodriguez
2012-03-26 8:49 ` Johannes Berg
2012-03-26 12:58 ` Luis R. Rodriguez
2012-03-28 10:00 ` Luis R. Rodriguez
2012-04-05 12:33 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333629184.3494.12.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=lf_driver_backport@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@bombadil.infradead.org \
--cc=mcgrof@frijolero.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox