From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: CONFIG_RTLWIFI_DEBUG default y
Date: Mon, 02 Apr 2012 10:29:28 -0700 [thread overview]
Message-ID: <1333387768.20402.7.camel@joe2Laptop> (raw)
In-Reply-To: <20120402171733.GB13264@x1.osrc.amd.com>
On Mon, 2012-04-02 at 19:17 +0200, Borislav Petkov wrote:
> On Mon, Apr 02, 2012 at 09:53:38AM -0700, Joe Perches wrote:
> > To keep all the "printk(KERN_DEBUG" to "pr_debug(" conversion
> > output the same as the it was prior to the patch.
> >
> > Larry can default it to off if he wants.
>
> >From looking at one user of this -
> drivers/net/wireless/rtlwifi/rtl8192ce/hw.c - some of the messages look
> like important ones which you wanna have enabled always, f.e. error
> handling in rtl92ce_hw_init().
>
> It probably needs splitting into debugging messages which are default n
> and always-on messages.
>From my perspective, anything KERN_DEBUG that should always be
output should not be KERN_DEBUG but some other KERN_<LEVEL>.
next prev parent reply other threads:[~2012-04-02 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 16:49 CONFIG_RTLWIFI_DEBUG default y Borislav Petkov
2012-04-02 16:53 ` Joe Perches
2012-04-02 17:17 ` Borislav Petkov
2012-04-02 17:29 ` Joe Perches [this message]
2012-04-02 17:45 ` Larry Finger
2012-04-02 18:08 ` Joe Perches
2012-04-02 20:32 ` Borislav Petkov
2012-04-02 20:46 ` Larry Finger
2012-04-02 20:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333387768.20402.7.camel@joe2Laptop \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox