From: Borislav Petkov <bp@alien8.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: Re: CONFIG_RTLWIFI_DEBUG default y
Date: Mon, 2 Apr 2012 22:53:22 +0200 [thread overview]
Message-ID: <20120402205322.GA31126@liondog.tnic> (raw)
In-Reply-To: <4F7A103E.90007@lwfinger.net>
On Mon, Apr 02, 2012 at 03:46:54PM -0500, Larry Finger wrote:
> Users will see nothing more than before!
>
> Before CONFIG_RTLWIFI_DEBUG was allowed to be set, the driver always
> compiled in the debug code, but only those messages with the
> DBG_EMERG code were actually output. With the parameter set to Y,
> nothing changed. If the module is loaded with the "debug=X" option,
> where X is greater than 0, then other messages will be seen. That
> dynamic setting of the level is enough.
>
> The only change when the configuration parameter is set to N is that
> the entire debug setup compiles away. The driver is a lot smaller,
> but there is no debugging.
Yes, yes, I knew there should be some sane default there,
rtlpriv->dbg.global_debuglevel remains 0 which is DBG_EMERG. I stand
corrected, thanks.
--
Regards/Gruss,
Boris.
prev parent reply other threads:[~2012-04-02 20:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 16:49 CONFIG_RTLWIFI_DEBUG default y Borislav Petkov
2012-04-02 16:53 ` Joe Perches
2012-04-02 17:17 ` Borislav Petkov
2012-04-02 17:29 ` Joe Perches
2012-04-02 17:45 ` Larry Finger
2012-04-02 18:08 ` Joe Perches
2012-04-02 20:32 ` Borislav Petkov
2012-04-02 20:46 ` Larry Finger
2012-04-02 20:53 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402205322.GA31126@liondog.tnic \
--to=bp@alien8.de \
--cc=Larry.Finger@lwfinger.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox