[PATCH 2/4][Trivial] lib/kobject.c : Check parameter in kobject_set_name

[PATCH 2/4][Trivial] lib/kobject.c : Check parameter in kobject_set_name

[yan]

kobject_set_name is exported and is just a wrapper for kobject_set_name_vargs
which does not check its parameter kobj. 
So check this parameter in kobject_set_name.


Signed-off-by: Yan Hong <clouds.yan@gmail.com>
---
 lib/kobject.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/lib/kobject.c b/lib/kobject.c
index 56c8cb3..dd67855 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -248,6 +248,9 @@ int kobject_set_name(struct kobject *kobj, const char *fmt, ...)
 	va_list vargs;
 	int retval;
 
+	if (!kobj)
+		return -EINVAL;
+
 	va_start(vargs, fmt);
 	retval = kobject_set_name_vargs(kobj, fmt, vargs);
 	va_end(vargs);
-- 
1.7.5.1

Re: [PATCH 2/4][Trivial] lib/kobject.c : Check parameter in kobject_set_name

[greg]

On Sat, Apr 21, 2012 at 05:31:24PM +0800, yan wrote:
> kobject_set_name is exported and is just a wrapper for kobject_set_name_vargs
> which does not check its parameter kobj. 
> So check this parameter in kobject_set_name.

I have the same objection to this patch, why is it needed?  All
in-kernel users do this properly, so the patch isn't needed.

Remember, kernel programming isn't always about being defensive.

greg k-h