From: Joe Perches <joe@perches.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
jbaron@redhat.com
Subject: Re: [PATCH 2/3] params: replace printk(KERN_<LVL>...) with pr_<lvl>(...)
Date: Thu, 03 May 2012 12:23:52 -0700 [thread overview]
Message-ID: <1336073032.13866.42.camel@joe2Laptop> (raw)
In-Reply-To: <1336072371-23314-1-git-send-email-jim.cromie@gmail.com>
On Thu, 2012-05-03 at 13:12 -0600, Jim Cromie wrote:
> I left 1 printk which uses __FILE__, __LINE__ explicitly, which should
> not be subject to generic preferences expressed via pr_fmt().
[]
> diff --git a/kernel/params.c b/kernel/params.c
[]
> @@ -753,11 +747,9 @@ static struct module_kobject * __init locate_module_kobject(const char *name)
> #endif
> if (err) {
> kobject_put(&mk->kobj);
> - printk(KERN_ERR
> - "Module '%s' failed add to sysfs, error number %d\n",
> + pr_crit("Adding module '%s' to sysfs failed (%d), "
> + "the system may be unstable.\n",
> name, err);
> - printk(KERN_ERR
> - "The system will be unstable now.\n");
> return NULL;
> }
>
It'd be nicer to coalesce the formats and not worry about 80 columns.
Coalesced formats are easier to find via grep.
pr_crit("Adding module '%s' to sysfs failed (%d), the system may be unstable\n",
next prev parent reply other threads:[~2012-05-03 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 19:12 [PATCH 2/3] params: replace printk(KERN_<LVL>...) with pr_<lvl>(...) Jim Cromie
2012-05-03 19:23 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-04 0:22 Jim Cromie
2012-05-03 17:57 [PATCH 1/3] params.c: fix Smack complaint about parse_args Jim Cromie
2012-05-03 17:57 ` [PATCH 2/3] params: replace printk(KERN_<LVL>...) with pr_<lvl>(...) Jim Cromie
2012-05-03 18:50 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336073032.13866.42.camel@joe2Laptop \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox