* [PATCH] leds: lm3533: use devres to manage driver data
@ 2012-05-21 15:52 Johan Hovold
0 siblings, 0 replies; only message in thread
From: Johan Hovold @ 2012-05-21 15:52 UTC (permalink / raw)
To: Andrew Morton; +Cc: Richard Purdie, linux-kernel, Johan Hovold
Use devres to manage driver data.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
drivers/leds/leds-lm3533.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c
index 4ef496c..e968470 100644
--- a/drivers/leds/leds-lm3533.c
+++ b/drivers/leds/leds-lm3533.c
@@ -632,7 +632,7 @@ static int __devinit lm3533_led_probe(struct platform_device *pdev)
return -EINVAL;
}
- led = kzalloc(sizeof(*led), GFP_KERNEL);
+ led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL);
if (!led)
return -ENOMEM;
@@ -661,7 +661,7 @@ static int __devinit lm3533_led_probe(struct platform_device *pdev)
ret = led_classdev_register(pdev->dev.parent, &led->cdev);
if (ret) {
dev_err(&pdev->dev, "failed to register LED %d\n", pdev->id);
- goto err_free;
+ return ret;
}
led->cb.dev = led->cdev.dev;
@@ -688,8 +688,6 @@ err_sysfs_remove:
err_unregister:
led_classdev_unregister(&led->cdev);
flush_work_sync(&led->work);
-err_free:
- kfree(led);
return ret;
}
@@ -704,7 +702,6 @@ static int __devexit lm3533_led_remove(struct platform_device *pdev)
sysfs_remove_group(&led->cdev.dev->kobj, &lm3533_led_attribute_group);
led_classdev_unregister(&led->cdev);
flush_work_sync(&led->work);
- kfree(led);
return 0;
}
--
1.7.8.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-05-21 15:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-21 15:52 [PATCH] leds: lm3533: use devres to manage driver data Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox