From: Joe Perches <joe@perches.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Phil Carmody <ext-phil.2.carmody@nokia.com>,
linux-kernel@vger.kernel.org, apw@canonical.com
Subject: Re: [PATCH 1/1] checkpatch: don't fake typedefs with #define
Date: Tue, 22 May 2012 19:02:00 -0700 [thread overview]
Message-ID: <1337738520.13111.17.camel@joe2Laptop> (raw)
In-Reply-To: <4FBC4372.5070000@gmail.com>
On Wed, 2012-05-23 at 11:54 +1000, Ryan Mallon wrote:
> On 18/05/12 07:16, Phil Carmody wrote:
> > Too many. Alas I can't share them.
> That sounds like the cases you have seen are in code which is not
> public. I don't think I have ever seen code in the kernel, or in
> proposed patches which fakes a typedef with a #define.
>
> Is this an issue for public code, or for a private company tree? In the
> latter case, the checkpatch addition should go in your private tree,
> rather than mainline. It looks like, at least for mainline Linux, you
> are trying to solve a non-existent problem.
I agree it's pretty rare.
$ git grep -E "#\s*define\s+\w+\s+(struct|union)\b"|wc -l
57
Perhaps rarity shouldn't be enough to exclude the test though.
If Andy or Andrew wants to take it though, it's not a big
maintenance burden.
next prev parent reply other threads:[~2012-05-23 2:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 12:52 [PATCH 1/1] checkpatch: don't fake typedefs with #define Phil Carmody
2012-05-17 20:54 ` Joe Perches
2012-05-17 21:16 ` Phil Carmody
2012-05-17 21:24 ` Joe Perches
2012-05-21 12:05 ` Phil Carmody
2012-05-21 16:41 ` Joe Perches
2012-05-22 8:01 ` Phil Carmody
2012-05-22 16:48 ` Joe Perches
2012-05-23 1:54 ` Ryan Mallon
2012-05-23 2:02 ` Joe Perches [this message]
2012-05-23 2:50 ` Ryan Mallon
2012-05-23 3:25 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337738520.13111.17.camel@joe2Laptop \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox