From: Joe Perches <joe@perches.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Phil Carmody <ext-phil.2.carmody@nokia.com>,
linux-kernel@vger.kernel.org, apw@canonical.com
Subject: Re: [PATCH 1/1] checkpatch: don't fake typedefs with #define
Date: Tue, 22 May 2012 20:25:09 -0700 [thread overview]
Message-ID: <1337743509.13111.27.camel@joe2Laptop> (raw)
In-Reply-To: <4FBC505A.9000102@gmail.com>
On Wed, 2012-05-23 at 12:50 +1000, Ryan Mallon wrote:
[]
> #define __videocard struct card_info
> __attribute__((section(".videocards")))
> I'm guessing is because typedefs don't handle __attribute__.
Probably not and likely it shouldn't be
either a define or a typedef.
It's just not frequently used enough.
Maybe it could be more like
DEFINE_PCI_DEVICE_TABLE though that's
not pretty either.
> We could test for lots of things in checkpatch, but it seems more
> sensible to check for issues which are likely.
Maybe, but being comprehensive isn't
necessarily bad either.
Look at __setup, all the <foo>_ops tests,
the blackfin tests, etc. in checkpatch.
I don't care much one way or another.
Again, if Andrew or Andy wants to push it
forward, it's fine by me.
cheers, Joe
prev parent reply other threads:[~2012-05-23 3:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 12:52 [PATCH 1/1] checkpatch: don't fake typedefs with #define Phil Carmody
2012-05-17 20:54 ` Joe Perches
2012-05-17 21:16 ` Phil Carmody
2012-05-17 21:24 ` Joe Perches
2012-05-21 12:05 ` Phil Carmody
2012-05-21 16:41 ` Joe Perches
2012-05-22 8:01 ` Phil Carmody
2012-05-22 16:48 ` Joe Perches
2012-05-23 1:54 ` Ryan Mallon
2012-05-23 2:02 ` Joe Perches
2012-05-23 2:50 ` Ryan Mallon
2012-05-23 3:25 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337743509.13111.27.camel@joe2Laptop \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox