From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "'linux-kernel@vger.kernel.org' (linux-kernel@vger.kernel.org)"
<linux-kernel@vger.kernel.org>, "kay@vrfy.org" <kay@vrfy.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"mingo@elte.hu" <mingo@elte.hu>
Subject: RE: [PATCH] printk: fixing the deadlock when calling printk in nmi handle
Date: Wed, 04 Jul 2012 15:39:37 +0200 [thread overview]
Message-ID: <1341409177.2507.117.camel@laptop> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A10C84B@SHSMSX101.ccr.corp.intel.com>
On Wed, 2012-07-04 at 13:30 +0000, Liu, Chuansheng wrote:
> > Yuck.. and no. This makes sane things like early 8250 serial console less
> > reliable.
> Peter, could you share more?
You avoid calling console write, this delays writing the output, this
delay might be infinite if the machine is sick enough.
Things like the 8250 early console don't take locks and are fine to
call.
> I took many time to dig out this issue.
Well, it was a known issue..
> Anyway, in nmi handler, calling printk is dangerous. This patch is for this case.
But its ugly and decreases reliability.. Your 'solution' is to
basically ignore serialization and pray, that's not a solution, that's
gambling.
next prev parent reply other threads:[~2012-07-04 13:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 13:00 [PATCH] printk: fixing the deadlock when calling printk in nmi handle Liu, Chuansheng
2012-07-04 13:22 ` Peter Zijlstra
2012-07-04 13:30 ` Liu, Chuansheng
2012-07-04 13:39 ` Peter Zijlstra [this message]
2012-07-04 14:09 ` Peter Zijlstra
2012-07-04 14:12 ` Peter Zijlstra
2012-07-04 14:18 ` Liu, Chuansheng
2012-07-04 14:46 ` Liu, Chuansheng
2012-07-04 14:50 ` Peter Zijlstra
2012-07-04 14:52 ` Peter Zijlstra
2012-07-04 15:06 ` Liu, Chuansheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341409177.2507.117.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=chuansheng.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox