The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "'linux-kernel@vger.kernel.org' (linux-kernel@vger.kernel.org)" 
	<linux-kernel@vger.kernel.org>, "kay@vrfy.org" <kay@vrfy.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"mingo@elte.hu" <mingo@elte.hu>
Subject: RE: [PATCH] printk: fixing the deadlock when calling printk in nmi handle
Date: Wed, 04 Jul 2012 16:09:17 +0200	[thread overview]
Message-ID: <1341410957.2507.120.camel@laptop> (raw)
In-Reply-To: <1341409177.2507.117.camel@laptop>

On Wed, 2012-07-04 at 15:39 +0200, Peter Zijlstra wrote:
> > Anyway, in nmi handler, calling printk is dangerous. This patch is for this case.
> 
> But its ugly and decreases reliability..  Your 'solution' is to
> basically ignore serialization and pray, that's not a solution, that's
> gambling. 

If you want to fix it, do something like:

  http://marc.info/?l=linux-kernel&m=132446646923333


  reply	other threads:[~2012-07-04 14:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04 13:00 [PATCH] printk: fixing the deadlock when calling printk in nmi handle Liu, Chuansheng
2012-07-04 13:22 ` Peter Zijlstra
2012-07-04 13:30   ` Liu, Chuansheng
2012-07-04 13:39     ` Peter Zijlstra
2012-07-04 14:09       ` Peter Zijlstra [this message]
2012-07-04 14:12         ` Peter Zijlstra
2012-07-04 14:18           ` Liu, Chuansheng
2012-07-04 14:46       ` Liu, Chuansheng
2012-07-04 14:50         ` Peter Zijlstra
2012-07-04 14:52           ` Peter Zijlstra
2012-07-04 15:06             ` Liu, Chuansheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341410957.2507.120.camel@laptop \
    --to=peterz@infradead.org \
    --cc=chuansheng.liu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kay@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox