From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Alex Shi <alex.shi@intel.com>
Cc: tj@kernel.org, mingo@kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/numa: recovered SD_PERFER_SIBLING on CPU domain
Date: Fri, 20 Jul 2012 14:58:19 +0200 [thread overview]
Message-ID: <1342789099.2583.1.camel@twins> (raw)
In-Reply-To: <1342765190-21540-1-git-send-email-alex.shi@intel.com>
On Fri, 2012-07-20 at 14:19 +0800, Alex Shi wrote:
> commit 8e7fbcbc22c(sched: Remove stale power aware scheduling remnants
> and dysfunctional knobs) removed SD_PERFER_SIBLING on CPU domain
> On numa machine, that causes load_balance didn't perfer LCPU in same
> physical CPU package.
>
> It causes some regression on our numa machines from core2 to NHM and SNB.
> Recover this domain flag can recover the performance drop.
>
> This recovery doesn't has any bad impact on my all benchmarks specjbb,
> kbuild, fio, hackbench .. etc, on all my machines.
> Since it is a recovery, I assume it also has no bad impact for other
> platforms.
>
> Signed-off-by: Alex Shi <alex.shi@intel.com>
Thanks!
next prev parent reply other threads:[~2012-07-20 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 6:19 [PATCH] sched/numa: recovered SD_PERFER_SIBLING on CPU domain Alex Shi
2012-07-20 12:58 ` Peter Zijlstra [this message]
2012-07-26 15:07 ` [tip:sched/urgent] sched/numa: Add SD_PERFER_SIBLING to " tip-bot for Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342789099.2583.1.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox