From: Chuansheng Liu <chuansheng.liu@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: [PATCH] genirq: for edge interrupt IRQS_ONESHOT support with irq thread
Date: Fri, 12 Oct 2012 20:31:24 +0800 [thread overview]
Message-ID: <1350045084.13178.19.camel@cliu38-desktop-build> (raw)
In our system, there is one edge interrupt, and we want it to be
irq thread with IRQS_ONESHOT, and found in handle_edge_irq(),
even with IRQS_ONESHOT, the irq is still unmasked without care of
flag IRQS_ONESHOT.
It causes IRQS_ONESHOT can not work well for edge interrupt, but also
after the irq thread finished with flag IRQS_ONESHOT, the irq will be
possible to be unmasked again, it should be messing mask/unmask logic.
Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
---
kernel/irq/chip.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 57d86d0..f23f524 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -497,7 +497,13 @@ handle_edge_irq(unsigned int irq, struct irq_desc *desc)
kstat_incr_irqs_this_cpu(irq, desc);
/* Start handling the irq */
- desc->irq_data.chip->irq_ack(&desc->irq_data);
+ if (desc->istate & IRQS_ONESHOT) {
+ mask_ack_irq(desc);
+ handle_irq_event(desc);
+ cond_unmask_irq(desc);
+ goto out_unlock;
+ } else
+ desc->irq_data.chip->irq_ack(&desc->irq_data);
do {
if (unlikely(!desc->action)) {
--
1.7.0.4
next reply other threads:[~2012-10-12 3:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 12:31 Chuansheng Liu [this message]
2012-10-12 12:31 ` [PATCH] genirq: for edge interrupt IRQS_ONESHOT support with irq thread Thomas Gleixner
2012-10-12 12:38 ` Liu, Chuansheng
2012-10-12 12:46 ` Thomas Gleixner
2012-10-12 13:03 ` Liu, Chuansheng
2012-10-12 13:47 ` Thomas Gleixner
2012-10-12 14:35 ` Liu, Chuansheng
2012-10-12 20:58 ` Thomas Gleixner
2012-10-12 14:57 ` Liu, Chuansheng
2012-10-12 15:24 ` anish kumar
2012-10-12 15:29 ` Liu, Chuansheng
2012-10-12 15:37 ` anish kumar
2012-10-12 20:52 ` Thomas Gleixner
2012-10-13 5:21 ` anish kumar
2012-10-21 14:45 ` anish kumar
2012-10-12 20:53 ` Thomas Gleixner
2012-10-12 13:39 ` Liu, Chuansheng
2012-10-12 15:32 ` irq/manage.c wrong comment( ? ) anish kumar
2012-10-21 14:46 ` anish kumar
2012-10-24 9:28 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350045084.13178.19.camel@cliu38-desktop-build \
--to=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox