* [PATCH] pinctrl: coh901: Return proper error if irq_domain_add_linear() fails
@ 2012-11-13 16:16 Axel Lin
2012-11-15 11:17 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-11-13 16:16 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel
Return -ENOMEM instead of 0 if irq_domain_add_linear fails.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/pinctrl-coh901.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-coh901.c b/drivers/pinctrl/pinctrl-coh901.c
index 5c7daf9..1144dcd 100644
--- a/drivers/pinctrl/pinctrl-coh901.c
+++ b/drivers/pinctrl/pinctrl-coh901.c
@@ -752,8 +752,10 @@ static int __init u300_gpio_probe(struct platform_device *pdev)
U300_GPIO_PINS_PER_PORT,
&irq_domain_simple_ops,
port);
- if (!port->domain)
+ if (!port->domain) {
+ err = -ENOMEM;
goto err_no_domain;
+ }
irq_set_chained_handler(port->irq, u300_gpio_irq_handler);
irq_set_handler_data(port->irq, port);
@@ -801,7 +803,7 @@ err_no_domain:
err_no_port:
u300_gpio_free_ports(gpio);
clk_disable_unprepare(gpio->clk);
- dev_info(&pdev->dev, "module ERROR:%d\n", err);
+ dev_err(&pdev->dev, "module ERROR:%d\n", err);
return err;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: coh901: Return proper error if irq_domain_add_linear() fails
2012-11-13 16:16 [PATCH] pinctrl: coh901: Return proper error if irq_domain_add_linear() fails Axel Lin
@ 2012-11-15 11:17 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2012-11-15 11:17 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel
On Tue, Nov 13, 2012 at 5:16 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Return -ENOMEM instead of 0 if irq_domain_add_linear fails.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-15 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-13 16:16 [PATCH] pinctrl: coh901: Return proper error if irq_domain_add_linear() fails Axel Lin
2012-11-15 11:17 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox