* [PATCH RFT] regulator: da9055: Fix checking wrong value in da9055_gpio_init
@ 2012-11-15 16:35 Axel Lin
2012-11-16 0:47 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-11-15 16:35 UTC (permalink / raw)
To: Mark Brown; +Cc: David Dajun Chen, Ashish Jangam, Liam Girdwood, linux-kernel
Check pdata->gpio_rsel && pdata->gpio_rsel[id] for the case GPI pin is muxed
with regulator to select the regulator register set A/B for voltage ramping.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Ashish,
I'm wondering if this is a typo or I misunderstand the code.
Axel
drivers/regulator/da9055-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c
index 8994178..79c5665 100644
--- a/drivers/regulator/da9055-regulator.c
+++ b/drivers/regulator/da9055-regulator.c
@@ -501,7 +501,7 @@ static __devinit int da9055_gpio_init(struct da9055_regulator *regulator,
goto err;
}
- if (pdata->gpio_rsel && pdata->gpio_ren[id]) {
+ if (pdata->gpio_rsel && pdata->gpio_rsel[id]) {
char name[18];
int gpio_mux = pdata->gpio_rsel[id];
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH RFT] regulator: da9055: Fix checking wrong value in da9055_gpio_init
2012-11-15 16:35 [PATCH RFT] regulator: da9055: Fix checking wrong value in da9055_gpio_init Axel Lin
@ 2012-11-16 0:47 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-11-16 0:47 UTC (permalink / raw)
To: Axel Lin; +Cc: David Dajun Chen, Ashish Jangam, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 270 bytes --]
On Fri, Nov 16, 2012 at 12:35:14AM +0800, Axel Lin wrote:
> Check pdata->gpio_rsel && pdata->gpio_rsel[id] for the case GPI pin is muxed
> with regulator to select the regulator register set A/B for voltage ramping.
Applied, thanks. Can revert if it's not a good fix.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-16 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-15 16:35 [PATCH RFT] regulator: da9055: Fix checking wrong value in da9055_gpio_init Axel Lin
2012-11-16 0:47 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox