The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Constantine Shulyupin <const@makelinux.com>
Cc: Andy Whitcroft <apw@canonical.com>,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v4] checkpatch: debugfs_remove() can take NULL
Date: Tue, 20 Nov 2012 06:58:23 -0800	[thread overview]
Message-ID: <1353423503.11235.12.camel@joe-AO722> (raw)
In-Reply-To: <CAE7jHC8LsxPaQHqy5-H4-wZp6q+_0s7arnPa3jG7R9x=tf_Oww@mail.gmail.com>

On Tue, 2012-11-20 at 16:50 +0200, Constantine Shulyupin wrote:
> >> On Tue, 2012-11-20 at 14:29 +0000, Andy Whitcroft wrote:
> >> Perhaps just
> >>                               WARN("NEEDLESS_IF",
> >
> > I would cirtainly be happy with that, I was trying to avoid changing the
> > capacity for the existing NEEDLESS_KFREE.  If compatibility there isn't
> > an issue then that makes life even simpler.
> >
> > -apw
> 
> Right.

I don't think it's an issue.  I'm not sure anyone
really uses --ignore for much other than LONG_LINE.





  reply	other threads:[~2012-11-20 14:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-17 22:20 [PATCH v4] checkpatch: debugfs_remove() can take NULL Constantine Shulyupin
2012-11-20 14:29 ` Andy Whitcroft
2012-11-20 14:43   ` Joe Perches
2012-11-20 14:47     ` Andy Whitcroft
2012-11-20 14:50       ` Constantine Shulyupin
2012-11-20 14:58         ` Joe Perches [this message]
2012-11-20 15:10           ` Constantine Shulyupin
2012-11-20 15:22             ` Andy Whitcroft
2012-11-20 20:57               ` [PATCH] checkpatch: Allow control over line length warning, default remains 80 Joe Perches
2012-11-20 15:37           ` [PATCH] checkpatch: consolidate if (foo) bar(foo) checks and add debugfs_remove Andy Whitcroft
2012-11-20 15:51             ` Joe Perches
2012-11-20 16:39               ` Andy Whitcroft
2012-11-20 18:37                 ` Joe Perches
2012-11-20 19:17                   ` [PATCH V2] " Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353423503.11235.12.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=const@makelinux.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox