* [PATCH] kfifo: initialize fifo accordingly to C99 standard
@ 2012-11-21 14:23 Andy Shevchenko
0 siblings, 0 replies; only message in thread
From: Andy Shevchenko @ 2012-11-21 14:23 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Shevchenko, Stefani Seibold, Greg Kroah-Hartman
When build a kernel with "make W=1" we will get a warning about missing
initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't
initialize the buf[] field of the fifo structure. So, using C99 style helps in
such case.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Stefani Seibold <stefani@seibold.net>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
---
include/linux/kfifo.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h
index 10308c6..3de51a1 100644
--- a/include/linux/kfifo.h
+++ b/include/linux/kfifo.h
@@ -155,8 +155,7 @@ struct kfifo_rec_ptr_2 __STRUCT_KFIFO_PTR(unsigned char, 2, void);
#define DEFINE_KFIFO(fifo, type, size) \
DECLARE_KFIFO(fifo, type, size) = \
(typeof(fifo)) { \
- { \
- { \
+ .kfifo = { \
.in = 0, \
.out = 0, \
.mask = __is_kfifo_ptr(&(fifo)) ? \
@@ -166,11 +165,9 @@ struct kfifo_rec_ptr_2 __STRUCT_KFIFO_PTR(unsigned char, 2, void);
.data = __is_kfifo_ptr(&(fifo)) ? \
NULL : \
(fifo).buf, \
- } \
} \
}
-
static inline unsigned int __must_check
__kfifo_uint_must_check_helper(unsigned int val)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-11-21 14:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 14:23 [PATCH] kfifo: initialize fifo accordingly to C99 standard Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox