From: Joe Perches <joe@perches.com>
To: wharms@bfs.de
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Russell King <linux@arm.linux.org.uk>,
Mike Rapoport <mike@compulab.co.il>,
Valdis.Kletnieks@vt.edu, cocci@systeme.lip6.fr,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, Paul Fulghum <paulkf@microgate.com>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: coccinelle and bitmask arithmetic
Date: Wed, 30 Jan 2013 00:29:23 -0800 [thread overview]
Message-ID: <1359534563.32305.6.camel@joe-AO722> (raw)
In-Reply-To: <5108D808.6010405@bfs.de>
On Wed, 2013-01-30 at 09:21 +0100, walter harms wrote:
> Am 29.01.2013 19:03, schrieb Joe Perches:
> > On Tue, 2013-01-29 at 18:49 +0100, Julia Lawall wrote:
> >> How about the following (from today's linux-next). They appear to be
> >> trying to do the same calculation, once with + and once with |.
> >
> > (cc'ing the original developer and Russell King)
> >
> > Likely the it8152_pci_platform_notify uses should use +
> >
> >> arch/arm/common/it8152.c
> >>
> >> int dma_set_coherent_mask(struct device *dev, u64 mask)
> >> {
> >> if (mask >= PHYS_OFFSET + SZ_64M - 1)
> >> return 0;
> >>
> >> return -EIO;
> >> }
> >>
>
> Great hit Joe :)
Julia and the others in the coccinelle group are the ones
with the whizzy program.
next prev parent reply other threads:[~2013-01-30 8:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 19:40 [patch] TTY: synclink, small cleanup in dtr_rts() Dan Carpenter
2013-01-27 20:04 ` Joe Perches
2013-01-27 20:16 ` Jiri Slaby
2013-01-27 20:19 ` Dan Carpenter
2013-01-27 21:00 ` Joe Perches
[not found] ` <C8AFB2C4-4974-4265-A41C-A56C71784F39@microgate.com>
2013-01-28 2:21 ` [PATCH] TTY: synclink: Convert + to | for bit operations Joe Perches
2013-01-28 12:06 ` [patch] TTY: synclink, small cleanup in dtr_rts() walter harms
2013-01-29 15:55 ` Valdis.Kletnieks
2013-01-29 16:13 ` coccinelle and bitmask arithmetic (was: Re: [patch] TTY: synclink, small cleanup in dtr_rts()) Joe Perches
2013-01-29 16:19 ` Julia Lawall
2013-01-29 16:31 ` Joe Perches
2013-01-29 17:30 ` Dan Carpenter
2013-01-29 17:42 ` Dan Carpenter
2013-01-29 17:49 ` Julia Lawall
2013-01-29 18:03 ` Joe Perches
2013-01-30 8:21 ` coccinelle and bitmask arithmetic walter harms
2013-01-30 8:29 ` Joe Perches [this message]
2013-01-30 11:14 ` Russell King - ARM Linux
2013-01-30 11:21 ` Julia Lawall
2013-01-30 11:35 ` Russell King - ARM Linux
2013-01-30 16:53 ` Joe Perches
2013-01-30 18:23 ` Russell King - ARM Linux
2013-01-29 18:38 ` coccinelle and bitmask arithmetic (was: Re: [patch] TTY: synclink, small cleanup in dtr_rts()) Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359534563.32305.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=cocci@systeme.lip6.fr \
--cc=dan.carpenter@oracle.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mike@compulab.co.il \
--cc=paulkf@microgate.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox