[PATCH] pinctrl: coh901: Fix error checking in u300_gpio_to_irq

[PATCH] pinctrl: coh901: Fix error checking in u300_gpio_to_irq

[Axel Lin]

The pointer "port" is always not NULL if gpio->port_list is not empty.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/pinctrl/pinctrl-coh901.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-coh901.c b/drivers/pinctrl/pinctrl-coh901.c
index 86887850..edde3ac 100644
--- a/drivers/pinctrl/pinctrl-coh901.c
+++ b/drivers/pinctrl/pinctrl-coh901.c
@@ -318,13 +318,16 @@ static int u300_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
 	struct u300_gpio_port *port = NULL;
 	struct list_head *p;
 	int retirq;
+	bool found = false;
 
 	list_for_each(p, &gpio->port_list) {
 		port = list_entry(p, struct u300_gpio_port, node);
-		if (port->number == portno)
+		if (port->number == portno) {
+			found = true;
 			break;
+		}
 	}
-	if (port == NULL) {
+	if (!found) {
 		dev_err(gpio->dev, "could not locate port for GPIO %d IRQ\n",
 			offset);
 		return -EINVAL;
-- 
1.7.10.4

Re: [PATCH] pinctrl: coh901: Fix error checking in u300_gpio_to_irq

[Linus Walleij]

On Thu, Mar 28, 2013 at 5:18 PM, Axel Lin <axel.lin@ingics.com> wrote:

> The pointer "port" is always not NULL if gpio->port_list is not empty.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Excellent catch Axel, thanks!!

Patch applied.

Yours,
Linus Walleij