From: Joe Perches <joe@perches.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Matthew Garrett <matthew.garrett@nebula.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Zhang Rui <rui.zhang@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH v3 1/1] Introduce Intel RAPL cooling device driver
Date: Tue, 09 Apr 2013 09:00:37 -0700 [thread overview]
Message-ID: <1365523237.6865.40.camel@joe-AO722> (raw)
In-Reply-To: <1365511578-30453-2-git-send-email-jacob.jun.pan@linux.intel.com>
On Tue, 2013-04-09 at 05:46 -0700, Jacob Pan wrote:
> RAPL(Running Average Power Limit) interface provides platform software
> with the ability to monitor, control, and get notifications on SOC
> power consumptions.
yet more trivia:
> diff --git a/drivers/platform/x86/intel_rapl.c b/drivers/platform/x86/intel_rapl.c
[]
> +static bool rapl_polling_should_cont(void)
> +{
> + unsigned int all_state = 0;
[]
> + return !!all_state;
The !! isn't needed.
!! should only be done when you are returning
int and you need to make sure it's 0 or 1.
It's not here. The return is bool.
return all_state;
The compiler, even icc, will do this internally.
> +static int start_periodic_polling(void)
> +{
> + if (polling_started)
> + goto out;
> + schedule_delayed_work(&rapl_polling_work, 0);
> + polling_started = true;
Should polling_started be device specific (in struct rapl_data ?)
instead of a single instance static?
next prev parent reply other threads:[~2013-04-09 16:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 12:46 [PATCH v3 0/1] RAPL (Running Average Power Limit) driver Jacob Pan
2013-04-09 12:46 ` [PATCH v3 1/1] Introduce Intel RAPL cooling device driver Jacob Pan
2013-04-09 15:26 ` Greg Kroah-Hartman
2013-04-09 15:53 ` Joe Perches
2013-04-09 16:07 ` Greg Kroah-Hartman
2013-04-09 16:29 ` Joe Perches
2013-04-09 16:15 ` Jacob Pan
2013-04-09 16:26 ` Joe Perches
2013-04-09 17:03 ` Jacob Pan
2013-04-09 16:34 ` Greg Kroah-Hartman
2013-04-09 16:00 ` Joe Perches [this message]
2013-04-09 23:22 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365523237.6865.40.camel@joe-AO722 \
--to=joe@perches.com \
--cc=arjan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox