From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Matthew Garrett <matthew.garrett@nebula.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Zhang Rui <rui.zhang@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH v3 1/1] Introduce Intel RAPL cooling device driver
Date: Tue, 9 Apr 2013 16:22:13 -0700 [thread overview]
Message-ID: <20130409162213.44cffcac@chromoly> (raw)
In-Reply-To: <1365523237.6865.40.camel@joe-AO722>
On Tue, 09 Apr 2013 09:00:37 -0700
Joe Perches <joe@perches.com> wrote:
> > +static int start_periodic_polling(void)
> > +{
> > + if (polling_started)
> > + goto out;
> > + schedule_delayed_work(&rapl_polling_work, 0);
> > + polling_started = true;
>
> Should polling_started be device specific (in struct rapl_data ?)
> instead of a single instance static?
hmmm, one of the future improvements is to add support for multi
package CPUs. I intend to use rapl_data for per package common data
across different domains but use a single polling thread to reduce
wakeups if we were to poll on multiple packages. So in that sense, I
want to keep the polling_started flag as a single instance within the
driver.
--
Thanks,
Jacob
prev parent reply other threads:[~2013-04-09 23:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 12:46 [PATCH v3 0/1] RAPL (Running Average Power Limit) driver Jacob Pan
2013-04-09 12:46 ` [PATCH v3 1/1] Introduce Intel RAPL cooling device driver Jacob Pan
2013-04-09 15:26 ` Greg Kroah-Hartman
2013-04-09 15:53 ` Joe Perches
2013-04-09 16:07 ` Greg Kroah-Hartman
2013-04-09 16:29 ` Joe Perches
2013-04-09 16:15 ` Jacob Pan
2013-04-09 16:26 ` Joe Perches
2013-04-09 17:03 ` Jacob Pan
2013-04-09 16:34 ` Greg Kroah-Hartman
2013-04-09 16:00 ` Joe Perches
2013-04-09 23:22 ` Jacob Pan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409162213.44cffcac@chromoly \
--to=jacob.jun.pan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox