From: Jon Mason <jon.mason@intel.com>
To: linux-kernel@vger.kernel.org
Cc: Dave Jiang <dave.jiang@intel.com>
Subject: [PATCH 10/10] NTB: Multiple NTB client fix
Date: Mon, 6 May 2013 18:55:29 -0700 [thread overview]
Message-ID: <1367891729-11738-11-git-send-email-jon.mason@intel.com> (raw)
In-Reply-To: <1367891729-11738-1-git-send-email-jon.mason@intel.com>
Fix issue with adding multiple ntb client devices to the ntb virtual
bus. Previously, multiple devices would be added with the same name,
resulting in crashes. To get around this issue, add a unique number to
the device when it is added.
Signed-off-by: Jon Mason <jon.mason@intel.com>
---
drivers/ntb/ntb_transport.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index 583a7d3..f8d7081 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -300,7 +300,7 @@ int ntb_register_client_dev(char *device_name)
{
struct ntb_transport_client_dev *client_dev;
struct ntb_transport *nt;
- int rc;
+ int rc, i = 0;
if (list_empty(&ntb_transport_list))
return -ENODEV;
@@ -318,7 +318,7 @@ int ntb_register_client_dev(char *device_name)
dev = &client_dev->dev;
/* setup and register client devices */
- dev_set_name(dev, "%s", device_name);
+ dev_set_name(dev, "%s%d", device_name, i);
dev->bus = &ntb_bus_type;
dev->release = ntb_client_release;
dev->parent = &ntb_query_pdev(nt->ndev)->dev;
@@ -330,6 +330,7 @@ int ntb_register_client_dev(char *device_name)
}
list_add_tail(&client_dev->entry, &nt->client_devs);
+ i++;
}
return 0;
--
1.7.9.5
prev parent reply other threads:[~2013-05-07 1:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 1:55 [PATCH 0/10] NTB: Bug Fixes Jon Mason
2013-05-07 1:55 ` [PATCH 01/10] NTB: variable dereferenced before check Jon Mason
2013-05-07 1:55 ` [PATCH 02/10] ntb: off by one sanity checks Jon Mason
2013-05-07 1:55 ` [PATCH 03/10] NTB: fix pointer math issues Jon Mason
2013-05-07 1:55 ` [PATCH 04/10] NTB: Handle 64bit BAR sizes Jon Mason
2013-05-07 1:55 ` [PATCH 05/10] NTB: Link toggle memory leak Jon Mason
2013-05-07 1:55 ` [PATCH 06/10] NTB: reset tx_index on link toggle Jon Mason
2013-05-07 1:55 ` [PATCH 07/10] NTB: Correctly handle receive buffers of the minimal size Jon Mason
2013-05-07 1:55 ` [PATCH 08/10] NTB: memcpy lockup workaround Jon Mason
2013-05-07 1:55 ` [PATCH 09/10] ntb_netdev: remove from list on exit Jon Mason
2013-05-07 1:55 ` Jon Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367891729-11738-11-git-send-email-jon.mason@intel.com \
--to=jon.mason@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox