From: Jon Mason <jon.mason@intel.com>
To: linux-kernel@vger.kernel.org
Cc: Dave Jiang <dave.jiang@intel.com>
Subject: [PATCH 06/10] NTB: reset tx_index on link toggle
Date: Mon, 6 May 2013 18:55:25 -0700 [thread overview]
Message-ID: <1367891729-11738-7-git-send-email-jon.mason@intel.com> (raw)
In-Reply-To: <1367891729-11738-1-git-send-email-jon.mason@intel.com>
If the NTB link toggles, the driver could stop receiving due to the
tx_index not being set to 0 on the transmitting size on a link-up event.
This is due to the driver expecting the incoming data to start at the
beginning of the receive buffer and not at a random place.
Signed-off-by: Jon Mason <jon.mason@intel.com>
---
drivers/ntb/ntb_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index be416d6..73a000e 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -505,6 +505,7 @@ static void ntb_transport_setup_qp_mw(struct ntb_transport *nt,
qp->rx_pkts = 0;
qp->tx_pkts = 0;
+ qp->tx_index = 0;
}
static void ntb_free_mw(struct ntb_transport *nt, int num_mw)
@@ -819,7 +820,6 @@ static void ntb_transport_init_queue(struct ntb_transport *nt,
qp->tx_mw = qp->rx_info + 1;
qp->tx_max_frame = min(transport_mtu, tx_size);
qp->tx_max_entry = tx_size / qp->tx_max_frame;
- qp->tx_index = 0;
if (nt->debugfs_dir) {
char debugfs_name[4];
--
1.7.9.5
next prev parent reply other threads:[~2013-05-07 1:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 1:55 [PATCH 0/10] NTB: Bug Fixes Jon Mason
2013-05-07 1:55 ` [PATCH 01/10] NTB: variable dereferenced before check Jon Mason
2013-05-07 1:55 ` [PATCH 02/10] ntb: off by one sanity checks Jon Mason
2013-05-07 1:55 ` [PATCH 03/10] NTB: fix pointer math issues Jon Mason
2013-05-07 1:55 ` [PATCH 04/10] NTB: Handle 64bit BAR sizes Jon Mason
2013-05-07 1:55 ` [PATCH 05/10] NTB: Link toggle memory leak Jon Mason
2013-05-07 1:55 ` Jon Mason [this message]
2013-05-07 1:55 ` [PATCH 07/10] NTB: Correctly handle receive buffers of the minimal size Jon Mason
2013-05-07 1:55 ` [PATCH 08/10] NTB: memcpy lockup workaround Jon Mason
2013-05-07 1:55 ` [PATCH 09/10] ntb_netdev: remove from list on exit Jon Mason
2013-05-07 1:55 ` [PATCH 10/10] NTB: Multiple NTB client fix Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367891729-11738-7-git-send-email-jon.mason@intel.com \
--to=jon.mason@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox