From: Jean Delvare <jdelvare@suse.de>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/3] firmware/dmi_scan: Constify strings
Date: Tue, 09 Jul 2013 18:23:32 +0200 [thread overview]
Message-ID: <1373387012.4391.14.camel@chaos.site> (raw)
In-Reply-To: <1373385495.14604.4.camel@joe-AO722>
Hi Joe,
Le Tuesday 09 July 2013 à 08:58 -0700, Joe Perches a écrit :
> On Tue, 2013-07-09 at 17:43 +0200, Jean Delvare wrote:
> > Add const to all DMI string pointers where this is possible. This
> > fixes a checkpatch warning.
>
> That's a nice little improvement.
Thanks.
> > +++ linux-3.10-rc0/drivers/firmware/dmi_scan.c 2013-05-04 11:20:52.808187924 +0200
> []
> > @@ -252,7 +252,7 @@ static void __init dmi_save_oem_strings_
> > struct dmi_device *dev;
> >
> > for (i = 1; i <= count; i++) {
> > - char *devname = dmi_string(dm, i);
> > + const char *devname = dmi_string(dm, i);
> >
> > if (devname == dmi_empty_string)
>
> btw: that last test sure looks like it would be
> better written as
> if (strcmp(devname, dmi_empty_string) == 0)
>
No, it does not. If you look at the rest of the code, the comparison
makes sense as is.
--
Jean Delvare
Suse L3
prev parent reply other threads:[~2013-07-09 16:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 15:40 [PATCH 0/3] firmware/dmi_scan: Cleanups Jean Delvare
2013-07-09 15:41 ` [PATCH 1/3] firmware/dmi_scan: Drop obsolete comment Jean Delvare
2013-07-09 15:42 ` [PATCH 2/3] firmware/dmi_scan: Fix most checkpatch errors and warnings Jean Delvare
2013-07-09 16:19 ` Joe Perches
2013-07-09 17:13 ` ia64: dmi.h: Make dmi_alloc use kzalloc Joe Perches
2013-07-09 20:43 ` Tony Luck
2013-07-10 12:28 ` [PATCH 2/3] firmware/dmi_scan: Fix most checkpatch errors and warnings Jean Delvare
2013-07-10 14:59 ` Joe Perches
2013-07-09 15:43 ` [PATCH 3/3] firmware/dmi_scan: Constify strings Jean Delvare
2013-07-09 15:58 ` Joe Perches
2013-07-09 16:23 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373387012.4391.14.camel@chaos.site \
--to=jdelvare@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox