The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* regulator: s2mps11: Question about the code updating ramp_delay setting
@ 2013-08-03  9:13 Axel Lin
  0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2013-08-03  9:13 UTC (permalink / raw)
  To: Yadwinder Singh Brar
  Cc: Mark Brown, Sangbeom Kim, Liam Girdwood, linux-kernel

Hi Yadwinder,
The code updating ramp_delay setting looks wrong to me.

Current code:
        return regmap_update_bits(rdev->regmap, ramp_reg,
                                  ramp_val << ramp_shift, 1 << ramp_shift);
I'd expect something like below:
        return regmap_update_bits(rdev->regmap, ramp_reg,
                                  ramp_mask << ramp_shift,
                                  ramp_val << ramp_shift);
I don't have the datasheet so I don't know the correct ramp_mask setting
here. Can you check if this needs fix?

Thanks,
Axel



^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2013-08-03  9:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-03  9:13 regulator: s2mps11: Question about the code updating ramp_delay setting Axel Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox