public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] imx-drm: imx-ldb: Staticize of_get_data_mapping()
@ 2013-09-02  1:11 Fabio Estevam
  2013-09-02  9:14 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-09-02  1:11 UTC (permalink / raw)
  To: gregkh; +Cc: s.hauer, p.zabel, linux-kernel, Fabio Estevam

From: Fabio Estevam <fabio.estevam@freescale.com>

Staticize of_get_data_mapping() in order to fix the following sparse warning:

drivers/staging/imx-drm/imx-ldb.c:424:11: warning: symbol 'of_get_data_mapping' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/staging/imx-drm/imx-ldb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c
index af733ea..b81ed41 100644
--- a/drivers/staging/imx-drm/imx-ldb.c
+++ b/drivers/staging/imx-drm/imx-ldb.c
@@ -421,7 +421,7 @@ static const char *imx_ldb_bit_mappings[] = {
 	[LVDS_BIT_MAP_JEIDA] = "jeida",
 };
 
-const int of_get_data_mapping(struct device_node *np)
+static const int of_get_data_mapping(struct device_node *np)
 {
 	const char *bm;
 	int ret, i;
-- 
1.8.1.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] imx-drm: imx-ldb: Staticize of_get_data_mapping()
  2013-09-02  1:11 [PATCH] imx-drm: imx-ldb: Staticize of_get_data_mapping() Fabio Estevam
@ 2013-09-02  9:14 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-09-02  9:14 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: gregkh, p.zabel, linux-kernel, Fabio Estevam

On Sun, Sep 01, 2013 at 10:11:55PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Staticize of_get_data_mapping() in order to fix the following sparse warning:
> 
> drivers/staging/imx-drm/imx-ldb.c:424:11: warning: symbol 'of_get_data_mapping' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>


Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

> ---
>  drivers/staging/imx-drm/imx-ldb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c
> index af733ea..b81ed41 100644
> --- a/drivers/staging/imx-drm/imx-ldb.c
> +++ b/drivers/staging/imx-drm/imx-ldb.c
> @@ -421,7 +421,7 @@ static const char *imx_ldb_bit_mappings[] = {
>  	[LVDS_BIT_MAP_JEIDA] = "jeida",
>  };
>  
> -const int of_get_data_mapping(struct device_node *np)
> +static const int of_get_data_mapping(struct device_node *np)
>  {
>  	const char *bm;
>  	int ret, i;
> -- 
> 1.8.1.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-02  9:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-02  1:11 [PATCH] imx-drm: imx-ldb: Staticize of_get_data_mapping() Fabio Estevam
2013-09-02  9:14 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox