The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] ARM: imx: Include linux/err.h
@ 2013-09-30 12:04 Thierry Reding
  2013-10-05  2:24 ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2013-09-30 12:04 UTC (permalink / raw)
  To: Sascha Hauer, Shawn Guo; +Cc: linux-arm-kernel, linux-kernel

The IS_ERR() macro is defined in the linux/err.h header file, so include
it explicitly.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 arch/arm/mach-imx/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/cpu.c b/arch/arm/mach-imx/cpu.c
index fae2c9a..ba3b498 100644
--- a/arch/arm/mach-imx/cpu.c
+++ b/arch/arm/mach-imx/cpu.c
@@ -1,4 +1,4 @@
-
+#include <linux/err.h>
 #include <linux/module.h>
 #include <linux/io.h>
 #include <linux/of.h>
-- 
1.8.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: imx: Include linux/err.h
  2013-09-30 12:04 [PATCH] ARM: imx: Include linux/err.h Thierry Reding
@ 2013-10-05  2:24 ` Shawn Guo
  2013-10-05  2:28   ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2013-10-05  2:24 UTC (permalink / raw)
  To: Thierry Reding; +Cc: Sascha Hauer, linux-arm-kernel, linux-kernel

On Mon, Sep 30, 2013 at 02:04:51PM +0200, Thierry Reding wrote:
> The IS_ERR() macro is defined in the linux/err.h header file, so include
> it explicitly.

Hmm, I can not find IS_ERR() in arch/arm/mach-imx/cpu.c

Shawn

> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  arch/arm/mach-imx/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/cpu.c b/arch/arm/mach-imx/cpu.c
> index fae2c9a..ba3b498 100644
> --- a/arch/arm/mach-imx/cpu.c
> +++ b/arch/arm/mach-imx/cpu.c
> @@ -1,4 +1,4 @@
> -
> +#include <linux/err.h>
>  #include <linux/module.h>
>  #include <linux/io.h>
>  #include <linux/of.h>
> -- 
> 1.8.4
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: imx: Include linux/err.h
  2013-10-05  2:24 ` Shawn Guo
@ 2013-10-05  2:28   ` Shawn Guo
  0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2013-10-05  2:28 UTC (permalink / raw)
  To: Thierry Reding; +Cc: linux-arm-kernel, Sascha Hauer, linux-kernel

On Sat, Oct 05, 2013 at 10:24:23AM +0800, Shawn Guo wrote:
> On Mon, Sep 30, 2013 at 02:04:51PM +0200, Thierry Reding wrote:
> > The IS_ERR() macro is defined in the linux/err.h header file, so include
> > it explicitly.
> 
> Hmm, I can not find IS_ERR() in arch/arm/mach-imx/cpu.c

Sorry, I did not look at the correct tree.

Applied, thanks.

Shawn


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-05  2:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 12:04 [PATCH] ARM: imx: Include linux/err.h Thierry Reding
2013-10-05  2:24 ` Shawn Guo
2013-10-05  2:28   ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox