The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Seth Forshee <seth.forshee@canonical.com>
Subject: [PATCH trace-cmd 1/5] trace-cmd/listen: Remove use of sighandler_t
Date: Thu, 24 Oct 2013 14:14:30 -0500	[thread overview]
Message-ID: <1382642074-15567-2-git-send-email-seth.forshee@canonical.com> (raw)
In-Reply-To: <1382642074-15567-1-git-send-email-seth.forshee@canonical.com>

sighandler_t is a GNU extension and may not be defined if
_GNU_SOURCE is not set. To minimize the potential for build
problems, change signal_setup() to declare its handle argument
the same way struct sigaction declares the sa_handler member.

Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
---
 trace-listen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trace-listen.c b/trace-listen.c
index 8b8f02c..0019089 100644
--- a/trace-listen.c
+++ b/trace-listen.c
@@ -69,7 +69,7 @@ static void put_temp_file(char *file)
 
 #define MAX_PATH 1024
 
-static void signal_setup(int sig, sighandler_t handle)
+static void signal_setup(int sig, void (*handle)(int))
 {
 	struct sigaction action;
 
-- 
1.8.3.2


  reply	other threads:[~2013-10-24 19:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 19:14 [PATCH trace-cmd 0/5] Miscellaneous fixes for trace-cmd Seth Forshee
2013-10-24 19:14 ` Seth Forshee [this message]
2013-10-24 20:30   ` [PATCH trace-cmd 1/5] trace-cmd/listen: Remove use of sighandler_t Seth Forshee
2013-10-28 15:45     ` Seth Forshee
2013-11-01 13:40       ` Steven Rostedt
2013-10-24 19:14 ` [PATCH trace-cmd 2/5] build: Install data files without execute permissions Seth Forshee
2013-10-25  8:31   ` Steven Rostedt
2013-10-25 13:05     ` Seth Forshee
2013-10-25 13:42       ` Steven Rostedt
2013-10-24 19:14 ` [PATCH trace-cmd 3/5] Add missing libgen.h includes Seth Forshee
2013-10-24 19:14 ` [PATCH trace-cmd 4/5] Documentation: Add kernelshark.1.txt Seth Forshee
2013-11-11  6:54   ` Rob Landley
2013-11-11 13:47     ` Seth Forshee
2013-10-24 19:14 ` [PATCH trace-cmd 5/5] build: Use CFLAGS and LDFLAGS when building python bits Seth Forshee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382642074-15567-2-git-send-email-seth.forshee@canonical.com \
    --to=seth.forshee@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox