From: Steven Rostedt <rostedt@goodmis.org>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH trace-cmd 2/5] build: Install data files without execute permissions
Date: Fri, 25 Oct 2013 04:31:33 -0400 [thread overview]
Message-ID: <1382689893.8356.2.camel@pippen.local.home> (raw)
In-Reply-To: <1382642074-15567-3-git-send-email-seth.forshee@canonical.com>
On Thu, 2013-10-24 at 14:14 -0500, Seth Forshee wrote:
> diff --git a/Makefile b/Makefile
> index 1964949..2423038 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -86,7 +86,8 @@ ifeq ($(shell sh -c "python-config --includes > /dev/null 2>&1 && echo y"), y)
> PYTHON_PLUGINS := plugin_python.so
> BUILD_PYTHON := $(PYTHON) $(PYTHON_PLUGINS)
> PYTHON_SO_INSTALL := ctracecmd.install
> - PYTHON_PY_INSTALL := event-viewer.install tracecmd.install tracecmdgui.install
> + PYTHON_PY_PROGS := event-viewer.install
> + PYTHON_PY_LIBS := tracecmd.install tracecmdgui.install
> endif
> endif # NO_PYTHON
>
> @@ -506,21 +507,32 @@ define do_install
> $(INSTALL) $1 '$(DESTDIR_SQ)$2'
> endef
>
> +define do_install_data
> + $(print_install) \
> + if [ ! -d '$(DESTDIR_SQ)$2' ]; then \
> + $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$2'; \
> + fi; \
> + $(INSTALL) -m 644 $1 '$(DESTDIR_SQ)$2'
> +endef
> +
> $(PLUGINS_INSTALL): %.install : %.so force
> - $(Q)$(call do_install,$<,$(plugin_dir_SQ))
> + $(Q)$(call do_install_data,$<,$(plugin_dir_SQ))
>
> install_plugins: $(PLUGINS_INSTALL)
>
> $(PYTHON_SO_INSTALL): %.install : %.so force
> - $(Q)$(call do_install,$<,$(python_dir_SQ))
> + $(Q)$(call do_install_data,$<,$(python_dir_SQ))
Hmm, I never realized that shared libraries are not suppose to be
executable. At first I thought this was a mistake, but looking at other
shared libraries on my system, it seems a lot are not executable
(although many are, but those may also be made by people like myself who
thought there were suppose to be).
Thanks,
-- Steve
>
> -$(PYTHON_PY_INSTALL): %.install : %.py force
> +$(PYTHON_PY_PROGS): %.install : %.py force
> $(Q)$(call do_install,$<,$(python_dir_SQ))
>
> +$(PYTHON_PY_LIBS): %.install : %.py force
> + $(Q)$(call do_install_data,$<,$(python_dir_SQ))
> +
> $(PYTHON_PY_PLUGINS): %.install : %.py force
> - $(Q)$(call do_install,$<,$(plugin_dir_SQ))
> + $(Q)$(call do_install_data,$<,$(plugin_dir_SQ))
>
> -install_python: $(PYTHON_SO_INSTALL) $(PYTHON_PY_INSTALL) $(PYTHON_PY_PLUGINS)
> +install_python: $(PYTHON_SO_INSTALL) $(PYTHON_PY_PROGS) $(PYTHON_PY_LIBS) $(PYTHON_PY_PLUGINS)
>
> install_cmd: all_cmd install_plugins install_python
> $(Q)$(call do_install,trace-cmd,$(bindir_SQ))
next prev parent reply other threads:[~2013-10-25 8:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 19:14 [PATCH trace-cmd 0/5] Miscellaneous fixes for trace-cmd Seth Forshee
2013-10-24 19:14 ` [PATCH trace-cmd 1/5] trace-cmd/listen: Remove use of sighandler_t Seth Forshee
2013-10-24 20:30 ` Seth Forshee
2013-10-28 15:45 ` Seth Forshee
2013-11-01 13:40 ` Steven Rostedt
2013-10-24 19:14 ` [PATCH trace-cmd 2/5] build: Install data files without execute permissions Seth Forshee
2013-10-25 8:31 ` Steven Rostedt [this message]
2013-10-25 13:05 ` Seth Forshee
2013-10-25 13:42 ` Steven Rostedt
2013-10-24 19:14 ` [PATCH trace-cmd 3/5] Add missing libgen.h includes Seth Forshee
2013-10-24 19:14 ` [PATCH trace-cmd 4/5] Documentation: Add kernelshark.1.txt Seth Forshee
2013-11-11 6:54 ` Rob Landley
2013-11-11 13:47 ` Seth Forshee
2013-10-24 19:14 ` [PATCH trace-cmd 5/5] build: Use CFLAGS and LDFLAGS when building python bits Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382689893.8356.2.camel@pippen.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox