public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <davidlohr@hp.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, dvhart@linux.intel.com, peterz@infradead.org,
	tglx@linutronix.de, efault@gmx.de, jeffm@suse.com,
	torvalds@linux-foundation.org, scott.norton@hp.com,
	tom.vaden@hp.com, aswin@hp.com, Waiman.Long@hp.com,
	jason.low2@hp.com, davidlohr@hp.com
Subject: [PATCH 2/5] futex: Check for pi futex_q only once
Date: Fri, 22 Nov 2013 16:56:34 -0800	[thread overview]
Message-ID: <1385168197-8612-3-git-send-email-davidlohr@hp.com> (raw)
In-Reply-To: <1385168197-8612-1-git-send-email-davidlohr@hp.com>

All wake_futex() callers already verify that the we are not dealing with
a pi futex_q, so we can remove the redundant WARN() check, as this is never
triggered anyway.

Cc: Ingo Molnar <mingo@kernel.org>
Cc: Darren Hart <dvhart@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Scott Norton <scott.norton@hp.com>
Cc: Tom Vaden <tom.vaden@hp.com>
Cc: Aswin Chandramouleeswaran <aswin@hp.com>
Cc: Waiman Long <Waiman.Long@hp.com>
Cc: Jason Low <jason.low2@hp.com>
Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
---
 kernel/futex.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/futex.c b/kernel/futex.c
index e6ffe73..0768c68 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -844,9 +844,6 @@ static void wake_futex(struct futex_q *q)
 {
 	struct task_struct *p = q->task;
 
-	if (WARN(q->pi_state || q->rt_waiter, "refusing to wake PI futex\n"))
-		return;
-
 	/*
 	 * We set q->lock_ptr = NULL _before_ we wake up the task. If
 	 * a non-futex wake up happens on another CPU then the task
-- 
1.8.1.4


  parent reply	other threads:[~2013-11-23  0:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-23  0:56 [PATCH 0/5] futex: Wakeup optimizations Davidlohr Bueso
2013-11-23  0:56 ` [PATCH 1/5] futex: Misc cleanups Davidlohr Bueso
2013-11-23  6:52   ` Darren Hart
2013-11-23  0:56 ` Davidlohr Bueso [this message]
2013-11-23  6:33   ` [PATCH 2/5] futex: Check for pi futex_q only once Darren Hart
2013-11-24  5:19     ` Davidlohr Bueso
2013-11-23  0:56 ` [PATCH 3/5] futex: Larger hash table Davidlohr Bueso
2013-11-23  6:52   ` Darren Hart
2013-11-23  0:56 ` [PATCH 4/5] futex: Avoid taking hb lock if nothing to wakeup Davidlohr Bueso
2013-11-23  1:25   ` Linus Torvalds
2013-11-23  3:03     ` Jason Low
2013-11-23  3:19     ` Davidlohr Bueso
2013-11-23  7:23       ` Darren Hart
2013-11-23 13:16       ` Thomas Gleixner
2013-11-24  3:46         ` Linus Torvalds
2013-11-24  5:15           ` Davidlohr Bueso
2013-11-25 12:01             ` Thomas Gleixner
2013-11-25 16:23           ` Thomas Gleixner
2013-11-25 16:36             ` Peter Zijlstra
2013-11-25 17:32               ` Thomas Gleixner
2013-11-25 17:38                 ` Peter Zijlstra
2013-11-25 18:55                 ` Davidlohr Bueso
2013-11-25 19:52                   ` Thomas Gleixner
2013-11-25 19:47         ` Thomas Gleixner
2013-11-25 20:03           ` Darren Hart
2013-11-25 20:26             ` Thomas Gleixner
2013-11-26 13:53             ` Thomas Gleixner
2013-11-23  4:05     ` Waiman Long
2013-11-23  5:40   ` Darren Hart
2013-11-23  5:42     ` Hart, Darren
2013-11-23  7:20   ` Darren Hart
2013-11-23  0:56 ` [PATCH 5/5] sched,futex: Provide delayed wakeup list Davidlohr Bueso
2013-11-23 11:48   ` Peter Zijlstra
2013-11-23 12:01     ` Peter Zijlstra
2013-11-24  5:25       ` Davidlohr Bueso
2013-11-23  5:55 ` [PATCH 0/5] futex: Wakeup optimizations Darren Hart
2013-11-23  6:35   ` Mike Galbraith
2013-11-23  6:38   ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385168197-8612-3-git-send-email-davidlohr@hp.com \
    --to=davidlohr@hp.com \
    --cc=Waiman.Long@hp.com \
    --cc=aswin@hp.com \
    --cc=dvhart@linux.intel.com \
    --cc=efault@gmx.de \
    --cc=jason.low2@hp.com \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=scott.norton@hp.com \
    --cc=tglx@linutronix.de \
    --cc=tom.vaden@hp.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox