public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration
@ 2014-02-25 15:52 Kirill Tkhai
  2014-02-25 16:20 ` Juri Lelli
  2014-02-27 13:31 ` [tip:sched/urgent] sched/deadline: Cleanup RT leftovers from {inc /dec}_dl_migration tip-bot for Kirill Tkhai
  0 siblings, 2 replies; 3+ messages in thread
From: Kirill Tkhai @ 2014-02-25 15:52 UTC (permalink / raw)
  To: linux-kernel; +Cc: juri.lelli, peterz, mingo


In deadline class we do not have group scheduling.

So, let's remove unnecessary

	X = X;

equations.

Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
CC: Juri Lelli <juri.lelli@gmail.com>
CC: Peter Zijlstra <peterz@infradead.org>
CC: Ingo Molnar <mingo@redhat.com>
---
 kernel/sched/deadline.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index ef96edc..2c28437 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -135,7 +135,6 @@ static void update_dl_migration(struct dl_rq *dl_rq)
 static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory++;
@@ -146,7 +145,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory--;




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration
  2014-02-25 15:52 [PATCH] sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration Kirill Tkhai
@ 2014-02-25 16:20 ` Juri Lelli
  2014-02-27 13:31 ` [tip:sched/urgent] sched/deadline: Cleanup RT leftovers from {inc /dec}_dl_migration tip-bot for Kirill Tkhai
  1 sibling, 0 replies; 3+ messages in thread
From: Juri Lelli @ 2014-02-25 16:20 UTC (permalink / raw)
  To: Kirill Tkhai; +Cc: linux-kernel, peterz, mingo

On Tue, 25 Feb 2014 19:52:23 +0400
Kirill Tkhai <ktkhai@parallels.com> wrote:

> 
> In deadline class we do not have group scheduling.
> 
> So, let's remove unnecessary
> 
> 	X = X;
> 
> equations.
> 

Thanks!

- Juri

> Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
> CC: Juri Lelli <juri.lelli@gmail.com>
> CC: Peter Zijlstra <peterz@infradead.org>
> CC: Ingo Molnar <mingo@redhat.com>
> ---
>  kernel/sched/deadline.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index ef96edc..2c28437 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -135,7 +135,6 @@ static void update_dl_migration(struct dl_rq *dl_rq)
>  static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
>  {
>  	struct task_struct *p = dl_task_of(dl_se);
> -	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
>  
>  	if (p->nr_cpus_allowed > 1)
>  		dl_rq->dl_nr_migratory++;
> @@ -146,7 +145,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
>  static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
>  {
>  	struct task_struct *p = dl_task_of(dl_se);
> -	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
>  
>  	if (p->nr_cpus_allowed > 1)
>  		dl_rq->dl_nr_migratory--;
> 
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:sched/urgent] sched/deadline: Cleanup RT leftovers from {inc /dec}_dl_migration
  2014-02-25 15:52 [PATCH] sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration Kirill Tkhai
  2014-02-25 16:20 ` Juri Lelli
@ 2014-02-27 13:31 ` tip-bot for Kirill Tkhai
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Kirill Tkhai @ 2014-02-27 13:31 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, ktkhai, hpa, mingo, peterz, tglx, juri.lelli

Commit-ID:  3908ac13b550c93f97d8db136ff572be5495bc06
Gitweb:     http://git.kernel.org/tip/3908ac13b550c93f97d8db136ff572be5495bc06
Author:     Kirill Tkhai <ktkhai@parallels.com>
AuthorDate: Tue, 25 Feb 2014 19:52:23 +0400
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 27 Feb 2014 12:29:39 +0100

sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration

In deadline class we do not have group scheduling.

So, let's remove unnecessary

	X = X;

equations.

Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@gmail.com>
Link: http://lkml.kernel.org/r/1393343543.4089.5.camel@tkhai
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/deadline.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 15cbc17..aecf930 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -135,7 +135,6 @@ static void update_dl_migration(struct dl_rq *dl_rq)
 static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory++;
@@ -146,7 +145,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory--;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-27 13:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-25 15:52 [PATCH] sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration Kirill Tkhai
2014-02-25 16:20 ` Juri Lelli
2014-02-27 13:31 ` [tip:sched/urgent] sched/deadline: Cleanup RT leftovers from {inc /dec}_dl_migration tip-bot for Kirill Tkhai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox