The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
	laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
	josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
	peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com,
	edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com,
	oleg@redhat.com, sbw@mit.edu
Subject: Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag
Date: Tue, 03 Jun 2014 15:49:08 -0700	[thread overview]
Message-ID: <1401835748.22133.13.camel@joe-AO725> (raw)
In-Reply-To: <20140603214809.GX22231@linux.vnet.ibm.com>

On Tue, 2014-06-03 at 14:48 -0700, Paul E. McKenney wrote:
> On Tue, Jun 03, 2014 at 01:16:07PM -0700, Joe Perches wrote:
> > On Tue, 2014-06-03 at 13:12 -0700, Paul E. McKenney wrote:
> > > On Tue, Jun 03, 2014 at 12:03:07PM -0700, Joe Perches wrote:
> > > > On Tue, 2014-06-03 at 08:35 -0700, Paul E. McKenney wrote:
> > > > > Paul Walmsley also noted the need for patch
> > > > > submitters to know who the key reviewers are and suggested adding an
> > > > > "R:" tag to the MAINTAINERS file to record this information on a
> > > > > per-subsystem basis.
> > > > []
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > []
> > > > > @@ -70,6 +70,8 @@ Descriptions of section entries:
> > > > >  
> > > > >  	P: Person (obsolete)
> > > > >  	M: Mail patches to: FullName <address@domain>
> > > > > +	R: Designated reviewer, who should be CCed on patches,
> > > > > +	   format: FullName <address@domain>
> > > > >  	L: Mailing list that is relevant to this area
> > > > >  	W: Web-page with status/info
> > > > >  	Q: Patchwork web based patch tracking system site
> > > > 
> > > > Perhaps the M: and R: roles should be more fully
> > > > described here.
> > > > 
> > > > The R: entry description doesn't need commas.
> > > > 
> > > > Maybe something like:
> > > > 	M: Maintainer (to:) FullName <address@domain>
> > > > 	R: Reviewer   (cc:) FullName <address@domain>
> > > 
> > > This is arguably better organized, but I need to keep my focus on adding
> > > the designated reviewer.  I am not in a position to undertake a rewrite
> > > of the MAINTAINER file preamble at this point.
> > 
> > That's silly, you're adding the "R" entry.
> > Add a proper description for it.
> 
> I will take another look at R: in a few days and possibly wordsmith it.

Swell, thanks.

> My reluctance is due to the fact that this will change how newbies
> submit patches.

Very, very doubtful that will change.

> But if we get a few Acked-by or Reviewed-by responses
> from high-level maintainers (Linus, Greg, Ingo, Thomas, Peter, Ted,
> Dave, Ben, ...), I will of course be happy to queue it.

cheers, Joe


      reply	other threads:[~2014-06-03 22:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 15:35 [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag Paul E. McKenney
2014-06-03 15:35 ` [PATCH v2 RFC 2/3] rcu: Add designated reviewers for RCU Paul E. McKenney
2014-06-03 15:35 ` [PATCH v2 RFC 3/3] Update RCU maintainership Paul E. McKenney
2014-06-03 16:14 ` [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag Steven Rostedt
2014-06-03 19:03 ` Joe Perches
2014-06-03 20:12   ` Paul E. McKenney
2014-06-03 20:16     ` Joe Perches
2014-06-03 21:48       ` Paul E. McKenney
2014-06-03 22:49         ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401835748.22133.13.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dvhart@linux.intel.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=niv@us.ibm.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sbw@mit.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox