* [PATCH] regulator: ltc3589: Use of_get_child_by_name
@ 2014-06-05 0:43 Axel Lin
2014-06-16 14:56 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2014-06-05 0:43 UTC (permalink / raw)
To: Mark Brown; +Cc: Philipp Zabel, Liam Girdwood, linux-kernel
of_find_node_by_name() walks the allnodes list, and can thus walk
outside of the parent node. Use of_get_child_by_name() instead.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/ltc3589.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/ltc3589.c b/drivers/regulator/ltc3589.c
index 110a99e..c810518 100644
--- a/drivers/regulator/ltc3589.c
+++ b/drivers/regulator/ltc3589.c
@@ -255,7 +255,7 @@ static int ltc3589_parse_regulators_dt(struct ltc3589 *ltc3589)
struct device_node *node;
int i, ret;
- node = of_find_node_by_name(dev->of_node, "regulators");
+ node = of_get_child_by_name(dev->of_node, "regulators");
if (!node) {
dev_err(dev, "regulators node not found\n");
return -EINVAL;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] regulator: ltc3589: Use of_get_child_by_name
2014-06-05 0:43 [PATCH] regulator: ltc3589: Use of_get_child_by_name Axel Lin
@ 2014-06-16 14:56 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-06-16 14:56 UTC (permalink / raw)
To: Axel Lin; +Cc: Philipp Zabel, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
On Thu, Jun 05, 2014 at 08:43:59AM +0800, Axel Lin wrote:
> of_find_node_by_name() walks the allnodes list, and can thus walk
> outside of the parent node. Use of_get_child_by_name() instead.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-16 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-05 0:43 [PATCH] regulator: ltc3589: Use of_get_child_by_name Axel Lin
2014-06-16 14:56 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox