From: Kirill Tkhai <ktkhai@parallels.com>
To: <linux-kernel@vger.kernel.org>
Cc: <peterz@infradead.org>, <pjt@google.com>, <oleg@redhat.com>,
<rostedt@goodmis.org>, <umgwanakikbuti@gmail.com>,
<tkhai@yandex.ru>, <tim.c.chen@linux.intel.com>,
<mingo@kernel.org>, <nicolas.pitre@linaro.org>
Subject: [PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq
Date: Wed, 6 Aug 2014 12:06:01 +0400 [thread overview]
Message-ID: <1407312361.8424.35.camel@tkhai> (raw)
In-Reply-To: <20140806075138.24858.23816.stgit@tkhai>
(sched_entity::on_rq == 1) does not guarantee the task is pickable;
changes on throttled cfs_rq must not lead to reschedule.
Check for task_struct::on_rq instead.
Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
---
kernel/sched/fair.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index bfa3c86..6f0ce2b 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7465,7 +7465,7 @@ static void task_fork_fair(struct task_struct *p)
static void
prio_changed_fair(struct rq *rq, struct task_struct *p, int oldprio)
{
- if (!p->se.on_rq)
+ if (!p->on_rq)
return;
/*
@@ -7521,15 +7521,15 @@ static void switched_from_fair(struct rq *rq, struct task_struct *p)
*/
static void switched_to_fair(struct rq *rq, struct task_struct *p)
{
- struct sched_entity *se = &p->se;
#ifdef CONFIG_FAIR_GROUP_SCHED
+ struct sched_entity *se = &p->se;
/*
* Since the real-depth could have been changed (only FAIR
* class maintain depth value), reset depth properly.
*/
se->depth = se->parent ? se->parent->depth + 1 : 0;
#endif
- if (!se->on_rq)
+ if (!p->on_rq)
return;
/*
next parent reply other threads:[~2014-08-06 8:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140806075138.24858.23816.stgit@tkhai>
2014-08-06 8:06 ` Kirill Tkhai [this message]
2014-08-20 8:20 ` [tip:sched/core] sched/fair: Fix reschedule which is generated on throttled cfs_rq tip-bot for Kirill Tkhai
2014-10-23 23:27 ` [PATCH v4 1/6] " Wanpeng Li
2014-10-24 6:01 ` Kirill Tkhai
2014-10-24 9:32 ` Wanpeng Li
2014-10-24 15:12 ` Kirill Tkhai
2014-08-06 8:06 ` [PATCH v4 2/6] sched: Wrapper for checking task_struct::on_rq Kirill Tkhai
2014-08-20 7:52 ` Ingo Molnar
2014-08-06 8:06 ` [PATCH v4 3/6] sched: Teach scheduler to understand ONRQ_MIGRATING state Kirill Tkhai
2014-08-12 7:55 ` Peter Zijlstra
2014-08-12 8:34 ` Kirill Tkhai
2014-08-12 9:43 ` Peter Zijlstra
2014-08-06 8:06 ` [PATCH v4 4/6] sched: Remove double_rq_lock() from __migrate_task() Kirill Tkhai
2014-08-12 8:21 ` Peter Zijlstra
2014-08-06 8:06 ` [PATCH v4 5/6] sched/fair: Remove double_lock_balance() from active_load_balance_cpu_stop() Kirill Tkhai
2014-08-12 9:03 ` Peter Zijlstra
2014-08-12 9:22 ` Peter Zijlstra
2014-08-12 9:39 ` Kirill Tkhai
2014-08-06 8:07 ` [PATCH v4 6/6] sched/fair: Remove double_lock_balance() from load_balance() Kirill Tkhai
2014-08-12 9:36 ` Peter Zijlstra
2014-08-12 10:27 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407312361.8424.35.camel@tkhai \
--to=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=tkhai@yandex.ru \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox