* [PATCH] mfd: sec-core: add missing sec_irq_init() return value checking
@ 2014-08-07 16:44 Bartlomiej Zolnierkiewicz
2014-08-07 16:48 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-08-07 16:44 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones
Cc: Krzysztof Kozlowski, Sangbeom Kim, Kyungmin Park, linux-kernel
sec_irq_init() can fail if it encounters unknown device type or
on regmap_add_irq_chip() error. Add missing sec_irq_init() return
value checking to sec_pmic_probe().
Tested on Insignal's Exynos4412 based Origen board.
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
patch is against next-20140804 branch of linux-next kernel
drivers/mfd/sec-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index dba7e2b..f498867 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
if (pdata && pdata->cfg_pmic_irq)
pdata->cfg_pmic_irq();
- sec_irq_init(sec_pmic);
+ ret = sec_irq_init(sec_pmic);
+ if (ret)
+ return ret;
pm_runtime_set_active(sec_pmic->dev);
--
1.8.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: sec-core: add missing sec_irq_init() return value checking
2014-08-07 16:44 [PATCH] mfd: sec-core: add missing sec_irq_init() return value checking Bartlomiej Zolnierkiewicz
@ 2014-08-07 16:48 ` Bartlomiej Zolnierkiewicz
2014-08-08 7:34 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-08-07 16:48 UTC (permalink / raw)
To: Samuel Ortiz
Cc: Lee Jones, Krzysztof Kozlowski, Sangbeom Kim, Kyungmin Park,
linux-kernel, linux-samsung-soc
[ added missing linux-samsung-soc ML, sorry for the noise ]
On Thursday, August 07, 2014 06:44:18 PM Bartlomiej Zolnierkiewicz wrote:
> sec_irq_init() can fail if it encounters unknown device type or
> on regmap_add_irq_chip() error. Add missing sec_irq_init() return
> value checking to sec_pmic_probe().
>
> Tested on Insignal's Exynos4412 based Origen board.
>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Sangbeom Kim <sbkim73@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> patch is against next-20140804 branch of linux-next kernel
>
> drivers/mfd/sec-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index dba7e2b..f498867 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
> if (pdata && pdata->cfg_pmic_irq)
> pdata->cfg_pmic_irq();
>
> - sec_irq_init(sec_pmic);
> + ret = sec_irq_init(sec_pmic);
> + if (ret)
> + return ret;
>
> pm_runtime_set_active(sec_pmic->dev);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: sec-core: add missing sec_irq_init() return value checking
2014-08-07 16:48 ` Bartlomiej Zolnierkiewicz
@ 2014-08-08 7:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2014-08-08 7:34 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Samuel Ortiz, Lee Jones, Sangbeom Kim, Kyungmin Park,
linux-kernel, linux-samsung-soc
On czw, 2014-08-07 at 18:48 +0200, Bartlomiej Zolnierkiewicz wrote:
> [ added missing linux-samsung-soc ML, sorry for the noise ]
>
> On Thursday, August 07, 2014 06:44:18 PM Bartlomiej Zolnierkiewicz wrote:
> > sec_irq_init() can fail if it encounters unknown device type or
> > on regmap_add_irq_chip() error. Add missing sec_irq_init() return
> > value checking to sec_pmic_probe().
> >
> > Tested on Insignal's Exynos4412 based Origen board.
> >
> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Cc: Sangbeom Kim <sbkim73@samsung.com>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > patch is against next-20140804 branch of linux-next kernel
> >
> > drivers/mfd/sec-core.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
Looks and works good (tested on board with S2MPS14).
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
> >
> > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> > index dba7e2b..f498867 100644
> > --- a/drivers/mfd/sec-core.c
> > +++ b/drivers/mfd/sec-core.c
> > @@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
> > if (pdata && pdata->cfg_pmic_irq)
> > pdata->cfg_pmic_irq();
> >
> > - sec_irq_init(sec_pmic);
> > + ret = sec_irq_init(sec_pmic);
> > + if (ret)
> > + return ret;
> >
> > pm_runtime_set_active(sec_pmic->dev);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-08 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-07 16:44 [PATCH] mfd: sec-core: add missing sec_irq_init() return value checking Bartlomiej Zolnierkiewicz
2014-08-07 16:48 ` Bartlomiej Zolnierkiewicz
2014-08-08 7:34 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox