[PATCH] regulator: Add stub function for devm_regulator_get_exclusive

[PATCH] regulator: Add stub function for devm_regulator_get_exclusive

[Axel Lin]

Fix below build error when !CONFIG_REGULATOR.

  CC      drivers/gpu/drm/msm/hdmi/hdmi.o
drivers/gpu/drm/msm/hdmi/hdmi.c: In function 'hdmi_init':
drivers/gpu/drm/msm/hdmi/hdmi.c:126:3: error: implicit declaration of function 'devm_regulator_get_exclusive' [-Werror=implicit-function-declaration]

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 include/linux/regulator/consumer.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h
index f8a8733..150d2f0 100644
--- a/include/linux/regulator/consumer.h
+++ b/include/linux/regulator/consumer.h
@@ -266,6 +266,12 @@ regulator_get_exclusive(struct device *dev, const char *id)
 }
 
 static inline struct regulator *__must_check
+devm_regulator_get_exclusive(struct device *dev, const char *id)
+{
+	return NULL;
+}
+
+static inline struct regulator *__must_check
 regulator_get_optional(struct device *dev, const char *id)
 {
 	return ERR_PTR(-ENODEV);
-- 
1.9.1

Re: [PATCH] regulator: Add stub function for devm_regulator_get_exclusive

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

On Sat, Aug 09, 2014 at 12:15:07PM +0800, Axel Lin wrote:

>  static inline struct regulator *__must_check
> +devm_regulator_get_exclusive(struct device *dev, const char *id)
> +{
> +	return NULL;
> +}
> +
> +static inline struct regulator *__must_check

This should be returning an error pointer, something wanting exclusive
control of a regulator would normally expect to have an actual regulator
and want to do things with it and so probably won't work well with a
dummy regulator.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]