public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: "Thierry Reding" <thierry.reding@gmail.com>,
	linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
	"Lothar Waßmann" <LW@KARO-electronics.de>,
	"Shawn Guo" <shawn.guo@linaro.org>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Tony Prisk" <linux@prisktech.co.nz>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 1/4] pwm: print error messages with pr_err() instead of pr_debug()
Date: Wed, 20 Aug 2014 08:55:53 +0200	[thread overview]
Message-ID: <1408517756-9412-2-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1408517756-9412-1-git-send-email-LW@KARO-electronics.de>

Make the messages that are printed in case of fatal errors actually
visible to the user without having to recompile the driver with
debugging enabled.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 drivers/pwm/core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 4b66bf0..7af0043 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -525,13 +525,13 @@ struct pwm_device *of_pwm_get(struct device_node *np, const char *con_id)
 	err = of_parse_phandle_with_args(np, "pwms", "#pwm-cells", index,
 					 &args);
 	if (err) {
-		pr_debug("%s(): can't parse \"pwms\" property\n", __func__);
+		pr_err("%s(): can't parse \"pwms\" property\n", __func__);
 		return ERR_PTR(err);
 	}
 
 	pc = of_node_to_pwmchip(args.np);
 	if (IS_ERR(pc)) {
-		pr_debug("%s(): PWM chip not found\n", __func__);
+		pr_err("%s(): PWM chip not found\n", __func__);
 		pwm = ERR_CAST(pc);
 		goto put;
 	}
-- 
1.7.10.4


  reply	other threads:[~2014-08-20  6:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20  6:55 [PATCHv4 0/4] pwm: imx: support output polarity inversion Lothar Waßmann
2014-08-20  6:55 ` Lothar Waßmann [this message]
2014-08-20  6:55   ` [PATCHv4 2/4] pwm: make the PWM_POLARITY flag in DTB optional Lothar Waßmann
2014-08-20  6:55     ` [PATCHv4 3/4] pwm: imx: indentation cleanup Lothar Waßmann
2014-08-20  6:55       ` [PATCHv4 4/4] pwm: imx: support output polarity inversion Lothar Waßmann
2014-08-26  7:39         ` Shawn Guo
2014-08-26  7:24 ` [PATCHv4 0/4] " Lothar Waßmann
2014-09-29 10:58   ` Sascha Hauer
2014-09-29 10:07 ` Lothar Waßmann
  -- strict thread matches above, loose matches on Subject: below --
2014-06-12 12:52 Lothar Waßmann
2014-06-12 12:52 ` [PATCHv4 1/4] pwm: print error messages with pr_err() instead of pr_debug() Lothar Waßmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408517756-9412-2-git-send-email-LW@KARO-electronics.de \
    --to=lw@karo-electronics.de \
    --cc=arnd@arndb.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@prisktech.co.nz \
    --cc=shawn.guo@linaro.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox