From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: "Thierry Reding" <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
"Lothar Waßmann" <LW@KARO-electronics.de>,
"Shawn Guo" <shawn.guo@linaro.org>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Tony Prisk" <linux@prisktech.co.nz>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 4/4] pwm: imx: support output polarity inversion
Date: Wed, 20 Aug 2014 08:55:56 +0200 [thread overview]
Message-ID: <1408517756-9412-5-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1408517756-9412-4-git-send-email-LW@KARO-electronics.de>
The i.MX pwm unit on i.MX27 and newer SoCs provides a configurable
output polarity. This patch adds support to utilize this feature where
available.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
drivers/pwm/pwm-imx.c | 38 +++++++++++++++++++++++++++++++++++---
1 file changed, 35 insertions(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index f836635..585b0a8 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -138,6 +138,8 @@ static int imx_pwm_config_v2(struct pwm_chip *chip,
if (test_bit(PWMF_ENABLED, &pwm->flags))
cr |= MX3_PWMCR_EN;
+ if (pwm->polarity == PWM_POLARITY_INVERSED)
+ cr |= MX3_PWMCR_POUTC;
writel(cr, imx->mmio_base + MX3_PWMCR);
@@ -156,6 +158,11 @@ static void imx_pwm_set_enable_v2(struct pwm_chip *chip, bool enable)
else
val &= ~MX3_PWMCR_EN;
+ if (chip->pwms[0].polarity == PWM_POLARITY_INVERSED)
+ val |= MX3_PWMCR_POUTC;
+ else
+ val &= ~MX3_PWMCR_POUTC;
+
writel(val, imx->mmio_base + MX3_PWMCR);
}
@@ -199,27 +206,49 @@ static void imx_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
clk_disable_unprepare(imx->clk_per);
}
-static struct pwm_ops imx_pwm_ops = {
+static int imx_pwm_set_polarity(struct pwm_chip *chip, struct pwm_device *pwm,
+ enum pwm_polarity polarity)
+{
+ struct imx_chip *imx = to_imx_chip(chip);
+
+ dev_dbg(imx->chip.dev, "%s: polarity set to %s\n", __func__,
+ polarity == PWM_POLARITY_INVERSED ? "inverted" : "normal");
+
+ return 0;
+}
+
+static struct pwm_ops imx_pwm_ops_v1 = {
.enable = imx_pwm_enable,
.disable = imx_pwm_disable,
.config = imx_pwm_config,
.owner = THIS_MODULE,
};
+static struct pwm_ops imx_pwm_ops_v2 = {
+ .enable = imx_pwm_enable,
+ .disable = imx_pwm_disable,
+ .set_polarity = imx_pwm_set_polarity,
+ .config = imx_pwm_config,
+ .owner = THIS_MODULE,
+};
+
struct imx_pwm_data {
int (*config)(struct pwm_chip *chip,
struct pwm_device *pwm, int duty_ns, int period_ns);
void (*set_enable)(struct pwm_chip *chip, bool enable);
+ struct pwm_ops *pwm_ops;
};
static struct imx_pwm_data imx_pwm_data_v1 = {
.config = imx_pwm_config_v1,
.set_enable = imx_pwm_set_enable_v1,
+ .pwm_ops = &imx_pwm_ops_v1,
};
static struct imx_pwm_data imx_pwm_data_v2 = {
.config = imx_pwm_config_v2,
.set_enable = imx_pwm_set_enable_v2,
+ .pwm_ops = &imx_pwm_ops_v2,
};
static const struct of_device_id imx_pwm_dt_ids[] = {
@@ -241,6 +270,10 @@ static int imx_pwm_probe(struct platform_device *pdev)
if (!of_id)
return -ENODEV;
+ data = of_id->data;
+ if (data->pwm_ops->set_polarity)
+ dev_dbg(&pdev->dev, "PWM supports output inversion\n");
+
imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
if (imx == NULL)
return -ENOMEM;
@@ -259,7 +292,7 @@ static int imx_pwm_probe(struct platform_device *pdev)
return PTR_ERR(imx->clk_ipg);
}
- imx->chip.ops = &imx_pwm_ops;
+ imx->chip.ops = data->pwm_ops;
imx->chip.dev = &pdev->dev;
imx->chip.base = -1;
imx->chip.npwm = 1;
@@ -270,7 +303,6 @@ static int imx_pwm_probe(struct platform_device *pdev)
if (IS_ERR(imx->mmio_base))
return PTR_ERR(imx->mmio_base);
- data = of_id->data;
imx->config = data->config;
imx->set_enable = data->set_enable;
--
1.7.10.4
next prev parent reply other threads:[~2014-08-20 6:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 6:55 [PATCHv4 0/4] pwm: imx: support output polarity inversion Lothar Waßmann
2014-08-20 6:55 ` [PATCHv4 1/4] pwm: print error messages with pr_err() instead of pr_debug() Lothar Waßmann
2014-08-20 6:55 ` [PATCHv4 2/4] pwm: make the PWM_POLARITY flag in DTB optional Lothar Waßmann
2014-08-20 6:55 ` [PATCHv4 3/4] pwm: imx: indentation cleanup Lothar Waßmann
2014-08-20 6:55 ` Lothar Waßmann [this message]
2014-08-26 7:39 ` [PATCHv4 4/4] pwm: imx: support output polarity inversion Shawn Guo
2014-08-26 7:24 ` [PATCHv4 0/4] " Lothar Waßmann
2014-09-29 10:58 ` Sascha Hauer
2014-09-29 10:07 ` Lothar Waßmann
-- strict thread matches above, loose matches on Subject: below --
2014-06-12 12:52 Lothar Waßmann
2014-06-12 12:52 ` [PATCHv4 1/4] pwm: print error messages with pr_err() instead of pr_debug() Lothar Waßmann
2014-06-12 12:52 ` [PATCHv4 2/4] pwm: make the PWM_POLARITY flag in DTB optional Lothar Waßmann
2014-06-12 12:52 ` [PATCHv4 3/4] pwm: imx: indentation cleanup Lothar Waßmann
2014-06-12 12:52 ` [PATCHv4 4/4] pwm: imx: support output polarity inversion Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408517756-9412-5-git-send-email-LW@KARO-electronics.de \
--to=lw@karo-electronics.de \
--cc=arnd@arndb.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=shawn.guo@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox