From: Kirill Tkhai <ktkhai@parallels.com>
To: <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, <tkhai@yandex.ru>
Subject: [PATCH 2/5] sched/fair: cleanup: Remove useless assignment in select_task_rq_fair()
Date: Fri, 12 Sep 2014 17:41:16 +0400 [thread overview]
Message-ID: <1410529276.3569.24.camel@tkhai> (raw)
In-Reply-To: <20140912132709.26840.4893.stgit@tkhai>
new_cpu is reassigned below, so we do not need this here.
Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
---
kernel/sched/fair.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index be9e97b..3d1c08a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4513,11 +4513,8 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f
if (p->nr_cpus_allowed == 1)
return prev_cpu;
- if (sd_flag & SD_BALANCE_WAKE) {
- if (cpumask_test_cpu(cpu, tsk_cpus_allowed(p)))
- want_affine = 1;
- new_cpu = prev_cpu;
- }
+ if (sd_flag & SD_BALANCE_WAKE)
+ want_affine = cpumask_test_cpu(cpu, tsk_cpus_allowed(p));
rcu_read_lock();
for_each_domain(cpu, tmp) {
next prev parent reply other threads:[~2014-09-12 13:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140912132709.26840.4893.stgit@tkhai>
2014-09-12 13:40 ` [PATCH 1/5] cleanup, treewide: Remove set_current_state(TASK_RUNNING) after schedule Kirill Tkhai
2014-09-19 11:44 ` [tip:sched/core] sched, cleanup, treewide: Remove set_current_state(TASK_RUNNING) after schedule() tip-bot for Kirill Tkhai
2014-09-12 13:41 ` Kirill Tkhai [this message]
2014-09-19 11:45 ` [tip:sched/core] sched/fair: cleanup: Remove useless assignment in select_task_rq_fair() tip-bot for Kirill Tkhai
2014-09-12 13:41 ` [PATCH 3/5] sched/core: Use put_prev_task() accessor where possible Kirill Tkhai
2014-09-19 11:45 ` [tip:sched/core] " tip-bot for Kirill Tkhai
2014-09-12 13:42 ` [PATCH 4/5] sched/rt: Remove useless if from cleanup pick_next_task_rt() Kirill Tkhai
2014-09-19 11:45 ` [tip:sched/core] " tip-bot for Kirill Tkhai
2014-09-12 13:42 ` [PATCH 5/5] sched/dl: Simplify pick_dl_task() Kirill Tkhai
2014-09-19 11:46 ` [tip:sched/core] " tip-bot for Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410529276.3569.24.camel@tkhai \
--to=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox